Toggle shared dirs based on the config option enable-shared-dirs

Use the config option to decide if shared directories should be
automatically configured during start

Author: anjannath

cmd/crc/cmd/start.go

@@ -74,6 +74,7 @@ func runStart(ctx context.Context) (*types.StartResult, error) {
 		PullSecret:        cluster.NewInteractivePullSecretLoader(config),
 		KubeAdminPassword: config.Get(crcConfig.KubeAdminPassword).AsString(),
 		Preset:            crcConfig.GetPreset(config),
+		EnableSharedDirs:  crcConfig.ShouldEnableSharedDirs(config),
 	}
 
 	client := newMachine()

pkg/crc/api/handlers.go

@@ -116,6 +116,7 @@ func getStartConfig(cfg crcConfig.Storage, args client.StartConfig) types.StartC
 		PullSecret:        cluster.NewNonInteractivePullSecretLoader(cfg, args.PullSecretFile),
 		KubeAdminPassword: cfg.Get(crcConfig.KubeAdminPassword).AsString(),
 		Preset:            crcConfig.GetPreset(cfg),
+		EnableSharedDirs:  crcConfig.ShouldEnableSharedDirs(cfg),
 	}
 }
 

pkg/crc/config/settings.go

@@ -145,6 +145,14 @@ func GetNetworkMode(config Storage) network.Mode {
 	return network.ParseMode(config.Get(NetworkMode).AsString())
 }
 
+func ShouldEnableSharedDirs(config Storage) bool {
+	// Shared dirs are not implemented for windows
+	if runtime.GOOS == "windows" {
+		return false
+	}
+	return config.Get(EnableSharedDirs).AsBool()
+}
+
 func UpdateDefaults(cfg *Config) {
 	RegisterSettings(cfg)
 }

pkg/crc/machine/start.go

@@ -367,9 +367,10 @@ func (client *client) Start(ctx context.Context, startConfig types.StartConfig)
 			return nil, errors.Wrap(err, "Failed to add nameserver to the VM")
 		}
 	}
-
-	if err := configureSharedDirs(vm, sshRunner); err != nil {
-		return nil, err
+	if startConfig.EnableSharedDirs {
+		if err := configureSharedDirs(vm, sshRunner); err != nil {
+			return nil, err
+		}
 	}
 
 	if _, _, err := sshRunner.RunPrivileged("make root Podman socket accessible", "chmod 777 /run/podman/ /run/podman/podman.sock"); err != nil {