Skip to content

Commit 2b3581d

Browse files
committed
Fix fetching tmpTables vs tmpDiskTables from performance_schema
The `perf_schema.eventsstatements` collector was incorrectly exposing "tmp_tables" as "tmp_disk_tables" and vice versa, due to query result being scanned in incorrect order. Closes prometheus#849 Signed-off-by: Cristian Greco <[email protected]>
1 parent dd8afce commit 2b3581d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

collector/perf_schema_events_statements.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ func (ScrapePerfEventsStatements) Scrape(ctx context.Context, db *sql.DB, ch cha
192192
)
193193
for perfSchemaEventsStatementsRows.Next() {
194194
if err := perfSchemaEventsStatementsRows.Scan(
195-
&schemaName, &digest, &digestText, &count, &queryTime, &errors, &warnings, &rowsAffected, &rowsSent, &rowsExamined, &tmpTables, &tmpDiskTables, &sortMergePasses, &sortRows, &noIndexUsed,
195+
&schemaName, &digest, &digestText, &count, &queryTime, &errors, &warnings, &rowsAffected, &rowsSent, &rowsExamined, &tmpDiskTables, &tmpTables, &sortMergePasses, &sortRows, &noIndexUsed,
196196
); err != nil {
197197
return err
198198
}

0 commit comments

Comments
 (0)