Skip to content

Commit 2142bc3

Browse files
author
Jonathan Wayne Parrott
committed
Merge pull request GoogleCloudPlatform#2 from GoogleCloudPlatform/linting
Add linting.
2 parents 12847ce + 9e64759 commit 2142bc3

File tree

6 files changed

+25
-10
lines changed

6 files changed

+25
-10
lines changed

.jshintrc

+13-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,15 @@
11
{
2-
"camelcase" : true,
3-
"indent" : 2,
4-
"strict" : true,
5-
"globalstrict" : true,
6-
"node" : true
2+
"camelcase" : true,
3+
"curly": true,
4+
"eqeqeq": true,
5+
"globalstrict": true,
6+
"indent": 2,
7+
"newcap": true,
8+
"maxlen": 80,
9+
"node": true,
10+
"quotmark": "single",
11+
"strict": true,
12+
"trailing": true,
13+
"undef": true,
14+
"unused": true
715
}

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@ install:
4040
#Use '-q' to disable interactive prompts
4141

4242
script:
43-
#Test and/or deploy your app with gcloud commands here!
43+
- jshint --exclude-path=.gitignore .

cloud-storage/authSample.js

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
* @fileoverview Sample code that grabs default credentials from the
33
* environment, then uses it to make an api call.
44
*/
5+
'use strict';
56

67
var google = require('googleapis');
78

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
},
1515
"devDependencies": {
1616
"mocha": "~2.2.5",
17+
"jshint": "~2.8.0",
1718
"lodash": "~3.10.1"
1819
},
1920
"repository": {

test/.jshintrc

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"extends": "../.jshintrc",
3+
"mocha": true
4+
}

test/cloud-storage/testAuthSample.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
/**
22
* @fileoverview Tests for the list-buckets module.
33
*/
4+
'use strict';
45

5-
var assert = require("assert");
6+
var assert = require('assert');
67
var _ = require('lodash');
78

8-
var authSample = require("../../cloud-storage/authSample");
9+
var authSample = require('../../cloud-storage/authSample');
910

1011
describe('listBuckets', function() {
11-
it('returns a list of buckets', function (done) {
12+
it('returns a list of buckets', function(done) {
1213
authSample.listBuckets(
1314
process.env.TEST_PROJECT_ID,
1415
function(error, success) {
@@ -17,7 +18,7 @@ describe('listBuckets', function() {
1718
} else {
1819
assert(success.items.length > 0);
1920
assert(_.find(success.items, function(item) {
20-
return item.name == process.env.TEST_BUCKET_NAME;
21+
return item.name === process.env.TEST_BUCKET_NAME;
2122
}));
2223
done();
2324
}

0 commit comments

Comments
 (0)