Skip to content

Commit 0b8695c

Browse files
committed
#379: Fix processing of hashes
1 parent 8846e81 commit 0b8695c

7 files changed

+20
-9
lines changed

lib/options/block-indent.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module.exports = (function() {
66
level = level || 0;
77

88
// XXX: Hack for braces
9-
if (node.is('braces')) return;
9+
if (node.is('braces') || node.is('id')) return;
1010

1111
for (var i = 0; i < node.length; i++) {
1212
var n = node.get(i);

lib/options/space-before-closing-brace.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ module.exports = (function() {
1919
level = level || 0;
2020

2121
// XXX: Hack for braces
22-
if (x.is('braces')) return;
22+
if (x.is('braces') || x.is('id')) return;
2323

2424
x.forEach(function(node) {
2525
if (!node.is('block') &&

lib/options/space-before-opening-brace.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ module.exports = (function() {
3535
process: function(node) {
3636
var value = this.getValue('space-before-opening-brace');
3737

38-
node.forEach(function(block, i) {
39-
// XXX: Hack for braces
40-
if (typeof block === 'string') return;
38+
// XXX: Hack for braces
39+
if (node.is('braces') || node.is('id')) return;
4140

41+
node.forEach(function(block, i) {
4242
// If found block node stop at the next one for space check:
4343
if (!block.is('block') && !block.is('atrulers')) return;
4444

@@ -71,10 +71,10 @@ module.exports = (function() {
7171
detect: function(node) {
7272
var variants = [];
7373

74-
node.forEach(function(block, i) {
75-
// XXX: Hack for braces
76-
if (typeof block === 'string') return;
74+
// XXX: Hack for braces
75+
if (node.is('braces') || node.is('id')) return [];
7776

77+
node.forEach(function(block, i) {
7878
// If found block node stop at the next one for space check:
7979
if (!block.is('block') && !block.is('atrulers')) return;
8080

lib/options/space-between-declarations.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ module.exports = (function() {
6767

6868
// TODO: Limit nodes to blocks, stylesheet, etc.
6969
// XXX: Hack for braces
70-
if (node.is('braces')) return;
70+
if (node.is('braces') || node.is('id')) return;
7171

7272
for (var i = 0, l = node.length; i < l; i++) {
7373
if (!node.get(i) || !node.get(i).is('declarationDelimiter')) continue;
+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
.pageArea #header {
2+
color: red;
3+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
.pageArea #header {
2+
color: red;
3+
}

test/options/block-indent/test.js

+5
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ describe('options/block-indent:', function() {
2424
this.shouldBeEqual('test.css', 'test-2.expected.css');
2525
});
2626

27+
it('Issue 379', function() {
28+
this.comb.configure({ 'block-indent': 4 });
29+
this.shouldBeEqual('issue-379.css', 'issue-379.expected.css');
30+
});
31+
2732
it('Should detect nothing with an empty block, test 1', function() {
2833
this.shouldDetect(
2934
['block-indent'],

0 commit comments

Comments
 (0)