Skip to content

Bundle is locked to mimemagic (0.3.4) in integration tests #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nard-tech opened this issue Mar 31, 2021 · 0 comments
Open

Bundle is locked to mimemagic (0.3.4) in integration tests #860

nard-tech opened this issue Mar 31, 2021 · 0 comments

Comments

@nard-tech
Copy link
Collaborator

nard-tech commented Mar 31, 2021

Maybe related to #859

mimemagic used in integration test (v0.3.4) is outdated.

As rails/rails#41750 shows, the license of mimemagic was changed to GPL 2.0 and reverted to MIT, and v0.3.4 was yanked.

The latest version of Rails (5.2.5, 6.0.3.6 and 6.1.3.1) do not depends on mimemagic, so we should use these latest Rails.

As I reported on #859, I tried to fix broken CI in #858. At the same time I tried to fix this issue (cf. 4052f18, 77088e0), but I could not fix entire problems due to other complicated reasons.

Links

Version

  • annotate version: 3.1.1
  • rails version: 5.2.4.1, 6.0.2.1
  • ruby version: 2.4, 2.5, 2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant