Reverse AfterAll execution order (#2456)

Author: davidjgoss

CHANGELOG.md

@@ -10,6 +10,7 @@ Please see [CONTRIBUTING.md](./CONTRIBUTING.md) on how to contribute to Cucumber
 ## [Unreleased]
 ### Fixed
 - Correctly report error in publish plugin ([#2454](https://github.com/cucumber/cucumber-js/pull/2454))
+- Reverse AfterAll execution order ([#2456](https://github.com/cucumber/cucumber-js/pull/2456))
 
 ## [11.1.0] - 2024-11-17
 ### Added

features/before_after_all_hooks.feature

@@ -15,6 +15,10 @@ Feature: Environment Hooks
       """
 
   Scenario: before all / after all hooks
+
+    BeforeAll hooks run once each before any scenarios, in declaration order
+    AfterAll hooks run once each after all scenarios, in reverse declaration order
+
     Given a file named "features/support/hooks.js" with:
       """
       const {AfterAll, BeforeAll, Given} = require('@cucumber/cucumber')
@@ -27,20 +31,30 @@ Feature: Environment Hooks
         counter += counter
       })
 
-      Given('first step', function() {
+      BeforeAll(function() {
         expect(counter).to.eql(2)
         counter += counter
       })
 
-      Given('second step', function() {
+      Given('first step', function() {
         expect(counter).to.eql(4)
         counter += counter
       })
 
-      AfterAll(function() {
+      Given('second step', function() {
         expect(counter).to.eql(8)
         counter += counter
       })
+
+      AfterAll(function() {
+        expect(counter).to.eql(32)
+        counter += counter
+      })
+
+      AfterAll(function() {
+        expect(counter).to.eql(16)
+        counter += counter
+      })
       """
     When I run cucumber-js
     Then it passes

package-lock.json

@@ -64,7 +64,7 @@ export class Worker {
 
   async runAfterAllHooks() {
     await this.runTestRunHooks(
-      this.supportCodeLibrary.afterTestRunHookDefinitions,
+      this.supportCodeLibrary.afterTestRunHookDefinitions.slice(0).reverse(),
       'an AfterAll'
     )
   }