Fix data table and tags handling in JSON formatter

Author: jbpros

lib/cucumber/listener/json_formatter.js

@@ -29,28 +29,30 @@ var JsonFormatter = function() {
       var tableContents   = step.getDataTable().getContents();
       var raw             = tableContents.raw();
       var tableProperties = [];
-      for (rawRow in raw) {
-        var row = {line: undefined, cells: raw[rawRow]};
+      raw.forEach(function (rawRow) {
+        var row = {line: undefined, cells: rawRow};
         tableProperties.push(row);
-      }
+      });
       stepProperties['rows'] = tableProperties;
     }
     gherkinJsonFormatter.step(stepProperties);
   }
 
   self.formatTags = function formatTags(tags, parentTags) {
     var tagsProperties = [];
-    for (tag in tags) {
+    tags.forEach(function (tag) {
       var isParentTag = false;
-      for (parentTag in parentTags) {
-        if ((tags[tag].getName() == parentTags[parentTag].getName()) && (tags[tag].getLine() == parentTags[parentTag].getLine())) {
-          isParentTag = true;
-        }
+      if (parentTags) {
+        parentTags.forEach(function (parentTag) {
+          if ((tag.getName() == parentTag.getName()) && (tag.getLine() == parentTag.getLine())) {
+            isParentTag = true;
+          }
+        });
       }
       if (!isParentTag) {
-        tagsProperties.push({name: tags[tag].getName(), line: tags[tag].getLine()});
+        tagsProperties.push({name: tag.getName(), line: tag.getLine()});
       }
-    }
+    });
     return tagsProperties;
   }
 

spec/cucumber/listener/json_formatter_spec.js

@@ -210,7 +210,7 @@ describe("Cucumber.Listener.JsonFormatterWrapper", function () {
   });
 
   describe("formatTags()", function () {
-    it("returns the given tags in the format expected by the JSON formatter", function (){
+    it("returns the given tags in the format expected by the JSON formatter", function () {
       var tags = [
         createSpyWithStubs("tag", {getName: "tag_one", getLine:1}),
         createSpyWithStubs("tag", {getName: "tag_two", getLine:2}),