handle spaces in the absolute path (#1845) (#1847)

* put quotes around the absolute path (#1845)

added quotes to wrap the path to summary.txt
to ensure that paths containing spaces are read properly

Co-authored-by: Matt Wynne <[email protected]>
Co-authored-by: Blaise Pabon <[email protected]>
Co-authored-by: Dane Parchment <[email protected]>

* fix indentations in feature file

* fixed the bug but needs unit testing

* fixed linting

* adds unit testing for handling paths with quotes

* adds the fix to option splitter files

* updated changelog and removed wip tag

Co-authored-by: Matt Wynne <[email protected]>
Co-authored-by: Blaise Pabon <[email protected]>
Co-authored-by: Dane Parchment <[email protected]>
Co-authored-by: Aslak Hellesøy <[email protected]>

Author: 5 people

CHANGELOG.md

@@ -9,6 +9,7 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO
 
 ## [Unreleased]
 ### Fixed
+- Handles spaces in paths for developers working on cucumbers's own code ([#1845](https://github.com/cucumber/cucumber-js/issues/1845))
 - Ensure package.json can be imported by consuming projects
   ([PR#1870](https://github.com/cucumber/cucumber-js/pull/1870)
    [Issue#1869](https://github.com/cucumber/cucumber-js/issues/1869))

features/formatter_paths.feature

@@ -25,7 +25,7 @@ Feature: Formatter Paths
 
   Scenario: Absolute path
     Given "{{{tmpDir}}}" is an absolute path
-    When I run cucumber-js with `-f summary:{{{tmpDir}}}/summary.txt`
+    When I run cucumber-js with `-f summary:"{{{tmpDir}}}/summary.txt"`
     Then the file "{{{tmpDir}}}/summary.txt" has the text:
       """
       1 scenario (1 passed)

src/cli/option_splitter.ts

@@ -1,5 +1,7 @@
 const OptionSplitter = {
   split(option: string): string[] {
+    option = option.replace(/"/g, '')
+
     const parts = option.split(/([^A-Z]):(?!\\)/)
 
     const result = parts.reduce((memo: string[], part: string, i: number) => {

src/cli/option_splitter_spec.ts

@@ -19,6 +19,11 @@ describe('OptionSplitter', () => {
       input: '/custom/formatter:/formatter/output.txt',
       output: ['/custom/formatter', '/formatter/output.txt'],
     },
+    {
+      description: 'splits paths with quotes around them',
+      input: '/custom/formatter:"/formatter directory/output.txt"',
+      output: ['/custom/formatter', '/formatter directory/output.txt'],
+    },
     {
       description: 'splits absolute windows paths',
       input: 'C:\\custom\\formatter:C:\\formatter\\output.txt',