Skip to content

improve timeout message #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charlierudolph opened this issue Jan 24, 2018 · 4 comments
Closed

improve timeout message #1019

charlierudolph opened this issue Jan 24, 2018 · 4 comments
Labels
good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team

Comments

@charlierudolph
Copy link
Member

Currently when a step times out, it only says "function timed out after x milliseconds". Lets try and make this more informative. Maybe something like:

  • with callback interface
    • function timed out, ensure the callback is executed within x milliseconds
  • with promise interface
    • function timed out, ensure the promise resolves within x milliseconds
@charlierudolph charlierudolph added good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team labels Jan 24, 2018
@stevecooperorg
Copy link

It would be really useful if this message could be updated by the user. I'm doing a lot of Selenium testing, and Selenium uses a 'wait until' model - 'wait for the dialog to appear' or 'wait until the server has responded'. If I could call something setTimeoutMessage('waiting for ' + dialogTitle + ' dialog to appear') and see The function timed out after 30,012 milliseconds: waiting for save dialog to appear that would really help us find out what exactly is going wrong in a test.

@charlierudolph
Copy link
Member Author

@stevecooperorg for that instance, I would update your code so selenium throws a timeout error before the step times out. Then you can control the error message there. Ideally, I don't think anyone should hit the step timeout error message regularly

We can add something about that to the new error message.

@charlierudolph
Copy link
Member Author

resolved in #1028

@lock
Copy link

lock bot commented Mar 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team
Projects
None yet
Development

No branches or pull requests

2 participants