Skip to content

Any way to end a feature test successfully when nodejs hangs? #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
totty90 opened this issue Jan 20, 2015 · 7 comments
Closed

Any way to end a feature test successfully when nodejs hangs? #296

totty90 opened this issue Jan 20, 2015 · 7 comments

Comments

@totty90
Copy link

totty90 commented Jan 20, 2015

I have a quite big app that hangs because of sockets. It doesn't end the feature and cucumber hangs. Is possible to force end the feature but with success?

@jbpros
Copy link
Member

jbpros commented Feb 7, 2015

I can't think of any straightforward way to do that reliably without losing some part of the output from Cucumber. Isn't it possible to close the sockets properly (which would be the right way of doing things anyway)?

@kaworu
Copy link

kaworu commented Feb 13, 2015

see also #262

@kaworu
Copy link

kaworu commented Feb 13, 2015

I have the same issue as you do. In my case, the problem is that another npm module (connection-mongostore) keep an open connection. The module does not offer any way to close it. While Cucumber hanging is fine when tests are run from the cli it's a real issue with CI (like Jenkins).

Leaving aside the Right Way™ debate, I am not sure that it is reasonable to think that all third parties module will cleanup or offer a way to do it. When one of them does not it's a world of pain to figure out which and why.

@totty90 as a workaround I am stuck using cucumber =0.4.0, which was the latest version that did not hang.

@totty90
Copy link
Author

totty90 commented Feb 13, 2015

@kaworu why the newer version hangs?

@kaworu
Copy link

kaworu commented Feb 13, 2015

@totty90 as I've written in #262 the fix is 1da47fb which reference #120.

@jbpros
Copy link
Member

jbpros commented Jul 3, 2015

Should be fixed by 23ff860. Please reopen is necessary.

@jbpros jbpros closed this as completed Jul 3, 2015
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants