[Code] Clean up unnecessary public modifiers (#1775)

JUnit 5 tests and test classes can be package private. The public
modifier simply adds nothing but ceremony. Cleaning this up will remove
a large number of inspection warnings.

Author: mpkorstanje

core/src/test/java/io/cucumber/core/backend/JavaObjectFactoryTest.java

@@ -10,21 +10,21 @@
 import static org.hamcrest.core.IsNull.notNullValue;
 import static org.junit.jupiter.api.Assertions.assertAll;
 
-public class JavaObjectFactoryTest {
+class JavaObjectFactoryTest {
 
     @Test
-    public void shouldGiveUsNewInstancesForEachScenario() {
+    void shouldGiveUsNewInstancesForEachScenario() {
         ObjectFactory factory = new DefaultJavaObjectFactory();
-        factory.addClass(SteDef.class);
+        factory.addClass(StepDefinition.class);
 
         // Scenario 1
         factory.start();
-        SteDef o1 = factory.getInstance(SteDef.class);
+        StepDefinition o1 = factory.getInstance(StepDefinition.class);
         factory.stop();
 
         // Scenario 2
         factory.start();
-        SteDef o2 = factory.getInstance(SteDef.class);
+        StepDefinition o2 = factory.getInstance(StepDefinition.class);
         factory.stop();
 
         assertAll("Checking SteDef",
@@ -34,7 +34,7 @@ public void shouldGiveUsNewInstancesForEachScenario() {
         );
     }
 
-    public static class SteDef {
+    public static class StepDefinition {
         // we just test the instances
     }
 

core/src/test/java/io/cucumber/core/feature/CucumberFeatureTest.java

@@ -16,18 +16,18 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
-public class CucumberFeatureTest {
+class CucumberFeatureTest {
 
     @Test
-    public void succeeds_if_no_features_are_found() {
+    void succeeds_if_no_features_are_found() {
         URI featurePath = URI.create("does/not/exist");
         ResourceLoader resourceLoader = mock(ResourceLoader.class);
         when(resourceLoader.resources(featurePath, ".feature")).thenReturn(Collections.emptyList());
         new FeatureLoader(resourceLoader).load(singletonList(featurePath));
     }
 
     @Test
-    public void gives_error_message_if_path_does_not_exist() {
+    void gives_error_message_if_path_does_not_exist() {
         URI featurePath = URI.create("path/bar.feature");
         ResourceLoader resourceLoader = mock(ResourceLoader.class);
         when(resourceLoader.resources(featurePath, ".feature")).thenThrow(new IllegalArgumentException("Not a file or directory: " + "path/bar.feature"));
@@ -39,7 +39,7 @@ public void gives_error_message_if_path_does_not_exist() {
     }
 
     @Test
-    public void gives_error_message_if_feature_on_class_path_does_not_exist() {
+    void gives_error_message_if_feature_on_class_path_does_not_exist() {
         URI featurePath = URI.create("classpath:path/bar.feature");
         ResourceLoader resourceLoader = mock(ResourceLoader.class);
         when(resourceLoader.resources(featurePath, ".feature")).thenReturn(emptyList());

core/src/test/java/io/cucumber/core/feature/FeatureBuilderTest.java

@@ -16,10 +16,10 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
-public class FeatureBuilderTest {
+class FeatureBuilderTest {
 
     @Test
-    public void ignores_duplicate_features() throws IOException {
+    void ignores_duplicate_features() throws IOException {
         FeatureBuilder builder = new FeatureBuilder();
         URI featurePath = URI.create("foo.feature");
         Resource resource1 = createResourceMock(featurePath);
@@ -34,7 +34,7 @@ public void ignores_duplicate_features() throws IOException {
     }
 
     @Test
-    public void works_when_path_and_uri_are_the_same() throws IOException {
+    void works_when_path_and_uri_are_the_same() throws IOException {
         URI featurePath = URI.create("path/foo.feature");
         Resource resource = createResourceMock(featurePath);
         FeatureBuilder builder = new FeatureBuilder();

core/src/test/java/io/cucumber/core/feature/FeatureIdentifierTest.java

@@ -11,10 +11,10 @@
 import static org.junit.jupiter.api.Assertions.assertAll;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
-public class FeatureIdentifierTest {
+class FeatureIdentifierTest {
 
     @Test
-    public void can_parse_feature_path_with_feature() {
+    void can_parse_feature_path_with_feature() {
         URI uri = FeatureIdentifier.parse(FeaturePath.parse("classpath:/path/to/file.feature"));
 
         assertAll("Checking uri",
@@ -24,7 +24,7 @@ public void can_parse_feature_path_with_feature() {
     }
 
     @Test
-    public void reject_feature_with_lines() {
+    void reject_feature_with_lines() {
         Executable testMethod = () -> FeatureIdentifier.parse(URI.create("classpath:/path/to/file.feature:10:40"));
         IllegalArgumentException actualThrown = assertThrows(IllegalArgumentException.class, testMethod);
         assertThat("Unexpected exception message", actualThrown.getMessage(), is(equalTo(
@@ -33,7 +33,7 @@ public void reject_feature_with_lines() {
     }
 
     @Test
-    public void reject_directory_form() {
+    void reject_directory_form() {
         Executable testMethod = () -> FeatureIdentifier.parse(URI.create("classpath:/path/to"));
         IllegalArgumentException actualThrown = assertThrows(IllegalArgumentException.class, testMethod);
         assertThat("Unexpected exception message", actualThrown.getMessage(), is(equalTo(

core/src/test/java/io/cucumber/core/feature/FeatureWithLinesTest.java

@@ -11,10 +11,10 @@
 import static org.hamcrest.core.IsEqual.equalTo;
 import static org.junit.jupiter.api.Assertions.assertAll;
 
-public class FeatureWithLinesTest {
+class FeatureWithLinesTest {
 
     @Test
-    public void should_create_FileWithFilters_with_no_lines() {
+    void should_create_FileWithFilters_with_no_lines() {
         FeatureWithLines featureWithLines = FeatureWithLines.parse("foo.feature");
 
         assertAll("Checking FeatureWithLines",
@@ -24,7 +24,7 @@ public void should_create_FileWithFilters_with_no_lines() {
     }
 
     @Test
-    public void should_create_FileWithFilters_with_1_line() {
+    void should_create_FileWithFilters_with_1_line() {
         FeatureWithLines featureWithLines = FeatureWithLines.parse("foo.feature:999");
 
         assertAll("Checking FeatureWithLines",
@@ -34,7 +34,7 @@ public void should_create_FileWithFilters_with_1_line() {
     }
 
     @Test
-    public void should_create_FileWithFilters_with_2_lines() {
+    void should_create_FileWithFilters_with_2_lines() {
         FeatureWithLines featureWithLines = FeatureWithLines.parse("foo.feature:999:2000");
 
         assertAll("Checking FeatureWithLines",

core/src/test/java/io/cucumber/core/io/DelegatingResourceIteratorFactoryTest.java

@@ -9,10 +9,10 @@
 import static org.hamcrest.core.Is.isA;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-public class DelegatingResourceIteratorFactoryTest {
+class DelegatingResourceIteratorFactoryTest {
 
     @Test
-    public void should_load_test_resource_iterator() {
+    void should_load_test_resource_iterator() {
         ResourceIteratorFactory factory =
             new DelegatingResourceIteratorFactory(new ZipThenFileResourceIteratorFactory());
         URI url = URI.create(TestResourceIteratorFactory.TEST_URL);

core/src/test/java/io/cucumber/core/io/FileResourceTest.java

@@ -10,10 +10,10 @@
 import static org.hamcrest.core.IsEqual.equalTo;
 import static org.junit.jupiter.api.Assertions.assertAll;
 
-public class FileResourceTest {
+class FileResourceTest {
 
     @Test
-    public void for_classpath_files_get_path_should_return_relative_path_from_classpath_root() {
+    void for_classpath_files_get_path_should_return_relative_path_from_classpath_root() {
         FileResource toTest1 = FileResource.createClasspathFileResource(new File("/testPath"), new File("/testPath/test1/test.feature"));
         FileResource toTest2 = FileResource.createClasspathFileResource(new File("testPath"), new File("testPath/test1/test.feature"));
 
@@ -24,7 +24,7 @@ public void for_classpath_files_get_path_should_return_relative_path_from_classp
     }
 
     @Test
-    public void for_filesystem_files_get_path_should_return_the_path() {
+    void for_filesystem_files_get_path_should_return_the_path() {
         // setup
         FileResource toTest1 = FileResource.createFileResource(new File("test1"), new File("test1/test.feature"));
         FileResource toTest2 = FileResource.createFileResource(new File("test1/test.feature"), new File("test1/test.feature"));

core/src/test/java/io/cucumber/core/io/FlatteningIteratorTest.java

@@ -16,10 +16,10 @@
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
-public class FlatteningIteratorTest {
+class FlatteningIteratorTest {
 
     @Test
-    public void flattens_iterators() {
+    void flattens_iterators() {
         final FlatteningIterator<Integer> fi = new FlatteningIterator<>();
         fi.push(asList(3, 4).iterator());
         fi.push(asList(1, 2).iterator());

core/src/test/java/io/cucumber/core/io/HelpersTest.java

@@ -10,10 +10,10 @@
 import static org.hamcrest.core.IsEqual.equalTo;
 import static org.junit.jupiter.api.Assertions.assertAll;
 
-public class HelpersTest {
+class HelpersTest {
 
     @Test
-    public void computes_file_path_for_jar_protocols() {
+    void computes_file_path_for_jar_protocols() {
 
         assertAll("Checking Helpers.jarFilePath",
             () -> assertThat(jarFilePath(URI.create("jar:file:foo%20bar+zap/cucumber-core.jar!/cucumber/runtime/io")).getSchemeSpecificPart(), is(equalTo("foo bar+zap/cucumber-core.jar"))),

core/src/test/java/io/cucumber/core/io/ZipResourceIteratorFactoryTest.java

@@ -9,10 +9,10 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 // https://github.com/cucumber/cucumber-jvm/issues/808
-public class ZipResourceIteratorFactoryTest {
+class ZipResourceIteratorFactoryTest {
 
     @Test
-    public void is_factory_for_jar_protocols() {
+    void is_factory_for_jar_protocols() {
         ZipResourceIteratorFactory factory = new ZipResourceIteratorFactory();
 
         assertAll("Checking ZipResourceIteratorFactory",

core/src/test/java/io/cucumber/core/logging/LoggerFactoryTest.java

@@ -50,7 +50,7 @@ protected boolean matchesSafely(LogRecord logRecord, Description description) {
     }
 
     @BeforeEach
-    public void setup() {
+    void setup() {
         Handler handler = new Handler() {
             @Override
             public void publish(LogRecord record) {
@@ -77,31 +77,31 @@ public void close() throws SecurityException {
     }
 
     @Test
-    public void error() {
+    void error() {
         logger.error("Error");
         assertThat(logged, logRecord("Error", Level.SEVERE, null));
         logger.error("Error", exception);
         assertThat(logged, logRecord("Error", Level.SEVERE, exception));
     }
 
     @Test
-    public void warn() {
+    void warn() {
         logger.warn("Warn");
         assertThat(logged, logRecord("Warn", Level.WARNING, null));
         logger.warn("Warn", exception);
         assertThat(logged, logRecord("Warn", Level.WARNING, exception));
     }
 
     @Test
-    public void info() {
+    void info() {
         logger.info("Info");
         assertThat(logged, logRecord("Info", Level.INFO, null));
         logger.info("Info", exception);
         assertThat(logged, logRecord("Info", Level.INFO, exception));
     }
 
     @Test
-    public void config() {
+    void config() {
         logger.config("Config");
         assertThat(logged, logRecord("Config", Level.CONFIG, null));
         logger.config("Config", exception);
@@ -110,15 +110,15 @@ public void config() {
 
 
     @Test
-    public void debug() {
+    void debug() {
         logger.debug("Debug");
         assertThat(logged, logRecord("Debug", Level.FINE, null));
         logger.debug("Debug", exception);
         assertThat(logged, logRecord("Debug", Level.FINE, exception));
     }
 
     @Test
-    public void trace() {
+    void trace() {
         logger.trace("Trace");
         assertThat(logged, logRecord("Trace", Level.FINER, null));
         logger.trace("Trace", exception);