Skip to content

Commit 11cd8ea

Browse files
committed
[Core] Activate some skipped tests.
1 parent a4eeece commit 11cd8ea

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

core/src/test/java/cucumber/runtime/RuntimeOptionsFactoryTest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -113,14 +113,14 @@ public void create_default_summary_printer_when_no_summary_printer_plugin_is_def
113113
assertPluginExists(runtimeOptions.getPlugins(), "cucumber.runtime.DefaultSummaryPrinter");
114114
}
115115

116-
@Test @org.junit.Ignore
116+
@Test
117117
public void inherit_plugin_from_baseclass() {
118118
RuntimeOptionsFactory runtimeOptionsFactory = new RuntimeOptionsFactory(SubClassWithFormatter.class);
119119
RuntimeOptions runtimeOptions = runtimeOptionsFactory.create();
120120

121121
List<Object> plugins = runtimeOptions.getPlugins();
122-
assertPluginExists(plugins, "cucumber.runtime.formatter.CucumberJSONFormatter");
123-
assertPluginExists(plugins, "cucumber.runtime.formatter.CucumberPrettyFormatter");
122+
assertPluginExists(plugins, "cucumber.runtime.formatter.JSONFormatter");
123+
assertPluginExists(plugins, "cucumber.runtime.formatter.PrettyFormatter");
124124
}
125125

126126
@Test

core/src/test/java/cucumber/runtime/RuntimeOptionsTest.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public void assigns_glue() {
7878
assertEquals(asList("somewhere"), options.getGlue());
7979
}
8080

81-
@Test @org.junit.Ignore
81+
@Test
8282
public void creates_html_formatter() {
8383
RuntimeOptions options = new RuntimeOptions(asList("--plugin", "html:some/dir", "--glue", "somewhere"));
8484
assertEquals("cucumber.runtime.formatter.HTMLFormatter", options.getPlugins().get(0).getClass().getName());
@@ -260,22 +260,22 @@ public void clobbers_line_filters_from_cli_if_features_specified_in_cucumber_opt
260260
assertEquals(asList("@keep_this"), runtimeOptions.getTagFilters());
261261
}
262262

263-
@Test @org.junit.Ignore
263+
@Test
264264
public void clobbers_formatter_plugins_from_cli_if_formatters_specified_in_cucumber_options_property() {
265265
Properties properties = new Properties();
266266
properties.setProperty("cucumber.options", "--plugin pretty");
267267
RuntimeOptions options = new RuntimeOptions(new Env(properties), asList("--plugin", "html:some/dir", "--glue", "somewhere"));
268-
assertPluginExists(options.getPlugins(), "cucumber.runtime.formatter.CucumberPrettyFormatter");
268+
assertPluginExists(options.getPlugins(), "cucumber.runtime.formatter.PrettyFormatter");
269269
assertPluginNotExists(options.getPlugins(), "cucumber.runtime.formatter.HTMLFormatter");
270270
}
271271

272-
@Test @org.junit.Ignore
272+
@Test
273273
public void adds_to_formatter_plugins_with_add_plugin_option() {
274274
Properties properties = new Properties();
275275
properties.setProperty("cucumber.options", "--add-plugin pretty");
276276
RuntimeOptions options = new RuntimeOptions(new Env(properties), asList("--plugin", "html:some/dir", "--glue", "somewhere"));
277277
assertPluginExists(options.getPlugins(), "cucumber.runtime.formatter.HTMLFormatter");
278-
assertPluginExists(options.getPlugins(), "cucumber.runtime.formatter.CucumberPrettyFormatter");
278+
assertPluginExists(options.getPlugins(), "cucumber.runtime.formatter.PrettyFormatter");
279279
}
280280

281281
@Test

0 commit comments

Comments
 (0)