fix: corrected test-case and improved Locale creation performance for #2902

Author: U117293

Diff for: cucumber-core/src/main/java/io/cucumber/core/runner/CachingGlue.java

@@ -87,6 +87,11 @@ final class CachingGlue implements Glue {
     private final EventBus bus;
     private StepTypeRegistry stepTypeRegistry;
     private Locale locale = null;
+    private int parameterTypeDefinitionsHashCode = 0;
+    private int stepDefinitionsHashCode = 0;
+    private int dataTableTypeDefinitionsHashCode = 0;
+    private int docStringTypeDefinitionsHashCode = 0;
+    private StepExpressionFactory stepExpressionFactory = null;
 
     CachingGlue(EventBus bus) {
         this.bus = bus;
@@ -237,12 +242,7 @@ List<DocStringTypeDefinition> getDocStringTypeDefinitions() {
     StepTypeRegistry getStepTypeRegistry() {
         return stepTypeRegistry;
     }
-    int parameterTypeDefinitionsHashCode = 0;
-    int stepDefinitionsHashCode = 0;
-    int dataTableTypeDefinitionsHashCode = 0;
-    int docStringTypeDefinitionsHashCode = 0;
 
-    StepExpressionFactory stepExpressionFactory = null;
     void prepareGlue(Locale locale) throws DuplicateStepDefinitionException {
         int parameterTypeDefinitionsHashCodeNew = parameterTypeDefinitions.hashCode();
         int dataTableTypeDefinitionsHashCodeNew = dataTableTypeDefinitions.hashCode();

Diff for: cucumber-core/src/main/java/io/cucumber/core/runner/Runner.java

@@ -21,8 +21,10 @@
 import java.net.URI;
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Locale;
+import java.util.Map;
 import java.util.Objects;
 import java.util.stream.Collectors;
 
@@ -39,6 +41,7 @@ public final class Runner {
     private final Collection<? extends Backend> backends;
     private final Options runnerOptions;
     private final ObjectFactory objectFactory;
+    private final Map<String, Locale> localeCache = new HashMap<>();
     private List<SnippetGenerator> snippetGenerators;
 
     public Runner(
@@ -80,7 +83,7 @@ public void runPickle(Pickle pickle) {
 
     private Locale localeForPickle(Pickle pickle) {
         String language = pickle.getLanguage();
-        return new Locale(language);
+        return localeCache.computeIfAbsent(language, (lang) -> new Locale(language));
     }
 
     public void runBeforeAllHooks() {