Skip to content

Commit 3f53eab

Browse files
committed
Merge #1236 'Correct the name of the Json Formatter embeddings node'
Also update Changelog.md.
2 parents 07027a2 + 34c0626 commit 3f53eab

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO
1111
### Removed
1212

1313
### Fixed
14+
* [Core] Correct the name of the Json Formatter embeddings node ([#1236](https://github.com/cucumber/cucumber-jvm/pull/1236) Haroon Sheikh)
1415

1516

1617
## [2.0.1-SNAPSHOT](https://github.com/cucumber/cucumber-jvm/compare/v2.0.0...v2.0.1) (2017-09-17)

core/src/main/java/cucumber/runtime/formatter/JSONFormatter.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -290,11 +290,11 @@ private void addOutputToHookMap(String text) {
290290
}
291291

292292
private void addEmbeddingToHookMap(byte[] data, String mimeType) {
293-
if (!currentStepOrHookMap.containsKey("embedding")) {
294-
currentStepOrHookMap.put("embedding", new ArrayList<Map<String, Object>>());
293+
if (!currentStepOrHookMap.containsKey("embeddings")) {
294+
currentStepOrHookMap.put("embeddings", new ArrayList<Map<String, Object>>());
295295
}
296296
Map<String, Object> embedMap = createEmbeddingMap(data, mimeType);
297-
((List<Map<String, Object>>)currentStepOrHookMap.get("embedding")).add(embedMap);
297+
((List<Map<String, Object>>)currentStepOrHookMap.get("embeddings")).add(embedMap);
298298
}
299299

300300
private Map<String, Object> createEmbeddingMap(byte[] data, String mimeType) {

core/src/test/java/cucumber/runtime/formatter/JSONFormatterTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ public void should_handle_embed_from_a_hooks() throws Throwable {
584584
" \"match\": {\n" +
585585
" \"location\": \"Hooks.before_hook_1()\"\n" +
586586
" },\n" +
587-
" \"embedding\": [\n" +
587+
" \"embeddings\": [\n" +
588588
" {\n" +
589589
" \"mime_type\": \"mime-type;base64\",\n" +
590590
" \"data\": \"AQID\"\n" +

0 commit comments

Comments
 (0)