OpenJdk8?

Author: mpkorstanje

.travis.yml

@@ -9,7 +9,7 @@ jobs:
   include:
   # 1.1 Semver check
   - stage: test
-    jdk: openjdk8
+    jdk: openjdk11
     script: mvn verify -Pcheck-semantic-version -DskipTests=true -DskipITs=true
     env: CHECK_SEMANTIC_VERSION=true
 
@@ -24,7 +24,7 @@ jobs:
   - jdk: openjdk11
     script: mvn -q verify
 
-  # 1.3 Check javadoc. We need to use this version to properly detect errors.
+  # 1.3 Check javadoc. This version should be used to build cucumber-jvm
   - jdk: openjdk11
     env: JAVADOC=true
     script:

archetype/pom.xml

@@ -9,9 +9,10 @@
         <version>5.1.0-SNAPSHOT</version>
     </parent>
 
+
     <artifactId>cucumber-archetype</artifactId>
     <packaging>maven-archetype</packaging>
-    <name>cucumber-archetype</name>
+    <name>Cucumber JVM: Archetype</name>
     <description>Cucumber JVM: Maven Archetype</description>
 
     <!-- Not used by this module, but used by the integration tests of

junit-platform-engine/pom.xml

@@ -1,4 +1,5 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
@@ -12,7 +13,7 @@
     <name>Cucumber-JVM: JUnit Platform Engine</name>
 
     <properties>
-        <project.Automatic-Module-Name>io.cucumber.junit.platform.engine</project.Automatic-Module-Name>
+        <javadoc.java.version>11</javadoc.java.version>
     </properties>
 
     <profiles>
@@ -83,4 +84,33 @@
         </dependency>
     </dependencies>
 
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-jar-plugin</artifactId>
+                <configuration combine.self="override">
+                    <!-- Ignore Automatic module name -->
+                    <archive>
+                        <manifestEntries>
+                            <Multi-Release>true</Multi-Release>
+                        </manifestEntries>
+                    </archive>
+                </configuration>
+            </plugin>
+
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-javadoc-plugin</artifactId>
+                <configuration>
+                    <source>8</source>
+                    <!-- Fails Javadoc generation-->
+                    <!-- <links>-->
+                    <!--    <link>https://junit.org/junit5/docs/current/api/</link>-->
+                    <!--</links>-->
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
 </project>

junit-platform-engine/src/main/java9/module-info.java

@@ -0,0 +1,14 @@
+module io.cucumber.junit.platform.engine {
+    requires org.opentest4j;
+    requires org.junit.platform.commons;
+    requires org.apiguardian.api;
+
+    requires io.cucumber.core;
+
+    requires transitive org.junit.platform.engine;
+
+    exports io.cucumber.junit.platform.engine;
+
+    provides org.junit.platform.engine.TestEngine with io.cucumber.junit.platform.engine.CucumberTestEngine;
+
+}

junit/pom.xml

@@ -1,4 +1,5 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
@@ -12,7 +13,6 @@
     <name>Cucumber-JVM: JUnit</name>
 
     <dependencies>
-
         <dependency>
             <groupId>org.apiguardian</groupId>
             <artifactId>apiguardian-api</artifactId>
@@ -45,4 +45,18 @@
     <properties>
         <project.Automatic-Module-Name>io.cucumber.junit</project.Automatic-Module-Name>
     </properties>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-javadoc-plugin</artifactId>
+                <configuration>
+                    <links>
+                        <link>https://junit.org/junit4/javadoc/latest/</link>
+                    </links>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
 </project>

openejb/pom.xml

@@ -74,7 +74,7 @@
 
     <!--
     Using source level 1.7 in combination with openejb-core results in 'An unknown compilation
-    error'. Use 1.6 instead and compile up to 1.7 to avoid this problem.
+    error'. Use 1.6 instead and compile up to avoid this problem.
      -->
     <build>
         <plugins>