Skip to content

Commit deecca8

Browse files
committed
* changed android maven plugin version to most recent release version 4.0.0 for example projects
* fixed structural problems with example projects and android maven plugin 4.x.x
1 parent 804c451 commit deecca8

File tree

32 files changed

+21
-19
lines changed

32 files changed

+21
-19
lines changed

examples/android/android-studio/Cukeulator/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ adb shell am instrument -w cukeulator.android.example.cucumber.cukeulator.test/c
6060
### Using an Android Studio IDE
6161
1. Import the example to Android Studio: `File > Import Project`.
6262
2. Make sure you have the cucumber-android jar dependencies in `app/libs/`.
63-
3. Create a test run confiruation:
63+
3. Create a test run configuration:
6464
1. Run > Edit Configurations
6565
2. Click `+` button and select Android Tests
6666
3. Specify test name: `CalculatorTest`

examples/android/android-test/pom.xml

+5-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
<groupId>info.cukes</groupId>
2020
<artifactId>cucumber-android</artifactId>
2121
<version>${project.version}</version>
22-
<type>apklib</type>
2322
</dependency>
2423
<dependency>
2524
<groupId>info.cukes</groupId>
@@ -32,12 +31,15 @@
3231
</dependencies>
3332

3433
<build>
35-
<sourceDirectory>src</sourceDirectory>
3634
<plugins>
3735
<plugin>
38-
<groupId>com.jayway.maven.plugins.android.generation2</groupId>
36+
<groupId>com.simpligility.maven.plugins</groupId>
3937
<artifactId>android-maven-plugin</artifactId>
4038
<extensions>true</extensions>
39+
<configuration>
40+
<!-- hack to workaround https://github.com/simpligility/android-maven-plugin/issues/548 -->
41+
<testCoverageFile>foo</testCoverageFile>
42+
</configuration>
4143
</plugin>
4244
</plugins>
4345
</build>

examples/android/cukeulator-test/README.md

+6-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
## Cukeulator Example Test
2-
This is the example test-project for the Cukeulator app.
2+
This is the example test-project for the Cukeulator app. Running the test assumes that the application itself has been install in your local repository like so:
3+
4+
```
5+
mvn install -pl examples/android/cukeulator -P android-examples
6+
```
37

48
### Setup
59
Features must be placed in `assets/features/`. Subdirectories are allowed.
@@ -23,7 +27,7 @@ To build:
2327
mvn package -pl examples/android/cukeulator-test -am -P android,android-examples
2428
```
2529

26-
To intall and run:
30+
To install and run:
2731

2832
```
2933
mvn install -pl examples/android/cukeulator-test -am -P android-examples

examples/android/cukeulator-test/pom.xml

+6-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
<groupId>info.cukes</groupId>
2020
<artifactId>cucumber-android</artifactId>
2121
<version>${project.version}</version>
22-
<type>apklib</type>
2322
</dependency>
2423
<dependency>
2524
<groupId>info.cukes</groupId>
@@ -46,12 +45,16 @@
4645
</dependencies>
4746

4847
<build>
49-
<sourceDirectory>src</sourceDirectory>
5048
<plugins>
5149
<plugin>
52-
<groupId>com.jayway.maven.plugins.android.generation2</groupId>
50+
<groupId>com.simpligility.maven.plugins</groupId>
5351
<artifactId>android-maven-plugin</artifactId>
5452
<extensions>true</extensions>
53+
<configuration>
54+
<!-- hack to workaround https://github.com/simpligility/android-maven-plugin/issues/548 -->
55+
<testCoverageFile>foo</testCoverageFile>
56+
<failOnNonStandardStructure>false</failOnNonStandardStructure>
57+
</configuration>
5558
</plugin>
5659
</plugins>
5760
</build>

examples/android/cukeulator/pom.xml

+1-2
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,9 @@
1515
<name>Examples: Android Cukeulator</name>
1616

1717
<build>
18-
<sourceDirectory>src</sourceDirectory>
1918
<plugins>
2019
<plugin>
21-
<groupId>com.jayway.maven.plugins.android.generation2</groupId>
20+
<groupId>com.simpligility.maven.plugins</groupId>
2221
<artifactId>android-maven-plugin</artifactId>
2322
<extensions>true</extensions>
2423
</plugin>

examples/android/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
<pluginManagement>
4444
<plugins>
4545
<plugin>
46-
<groupId>com.jayway.maven.plugins.android.generation2</groupId>
46+
<groupId>com.simpligility.maven.plugins</groupId>
4747
<artifactId>android-maven-plugin</artifactId>
4848
<version>${android-maven-plugin.version}</version>
4949
<configuration>

pom.xml

+1-7
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<slf4j.version>1.7.7</slf4j.version>
6262
<freemarker.version>2.3.21</freemarker.version>
6363
<javax.servlet-api.version>3.1.0</javax.servlet-api.version>
64-
<android-maven-plugin.version>4.0.0-rc.1</android-maven-plugin.version>
64+
<android-maven-plugin.version>4.0.0</android-maven-plugin.version>
6565
<android.version>4.1.1.4</android.version>
6666
<wicket.version>7.0.0-M3</wicket.version>
6767
<!-- We need a version that works with Java 6 and Java 7: http://www.eclipse.org/jetty/documentation/current/what-jetty-version.html -->
@@ -795,12 +795,6 @@
795795

796796
<!-- Non-standard plugins -->
797797

798-
<plugin>
799-
<groupId>com.jayway.maven.plugins.android.generation2</groupId>
800-
<artifactId>android-maven-plugin</artifactId>
801-
<version>3.9.0-rc.3</version>
802-
</plugin>
803-
804798
<plugin>
805799
<groupId>net.alchim31.maven</groupId>
806800
<artifactId>scala-maven-plugin</artifactId>

0 commit comments

Comments
 (0)