[Gherkin Vintage] Exclude background from pickle tree

Author: mpkorstanje

gherkin-messages/src/main/java/io/cucumber/core/gherkin/messages/GherkinMessagesFeature.java

@@ -67,7 +67,7 @@ public Pickle getPickleAt(Located located) {
         return pickles.stream()
             .filter(pickle -> pickle.getLocation().equals(location))
             .findFirst()
-            .orElseThrow(() -> new NoSuchElementException("No pickle at " + location));
+            .orElseThrow(() -> new NoSuchElementException("No pickle in " + uri + " at " + location));
     }
 
     @Override

gherkin-messages/src/main/java/io/cucumber/core/gherkin/messages/GherkinMessagesLocation.java

@@ -42,4 +42,12 @@ public int getColumn() {
     public int hashCode() {
         return Objects.hash(line, column);
     }
+
+    @Override
+    public String toString() {
+        return "Location{" +
+            "line=" + line +
+            ", column=" + column +
+            '}';
+    }
 }

gherkin-vintage/src/main/java/io/cucumber/core/gherkin/vintage/GherkinVintageFeature.java

@@ -1,6 +1,7 @@
 package io.cucumber.core.gherkin.vintage;
 
 import gherkin.ast.GherkinDocument;
+import gherkin.ast.Scenario;
 import gherkin.ast.ScenarioOutline;
 import io.cucumber.core.gherkin.Feature;
 import io.cucumber.core.gherkin.Located;
@@ -28,6 +29,9 @@ final class GherkinVintageFeature implements Feature {
         this.gherkinSource = gherkinSource;
         this.pickles = pickles;
         this.children = gherkinDocument.getFeature().getChildren().stream()
+            .filter(scenarioDefinition ->
+                (scenarioDefinition instanceof ScenarioOutline)
+                    || (scenarioDefinition instanceof Scenario))
             .map(scenarioDefinition -> {
                 if (scenarioDefinition instanceof ScenarioOutline) {
                     ScenarioOutline outline = (ScenarioOutline) scenarioDefinition;
@@ -54,7 +58,7 @@ public Pickle getPickleAt(Located located) {
         return pickles.stream()
             .filter(pickle -> pickle.getLocation().equals(location))
             .findFirst()
-            .orElseThrow(() -> new NoSuchElementException("No pickle at " + location));
+            .orElseThrow(() -> new NoSuchElementException("No pickle in " + uri + " at " + location));
     }
 
     @Override

gherkin-vintage/src/main/java/io/cucumber/core/gherkin/vintage/GherkinVintageLocation.java

@@ -46,4 +46,12 @@ public int getColumn() {
     public int hashCode() {
         return Objects.hash(line, column);
     }
+
+    @Override
+    public String toString() {
+        return "Location{" +
+            "line=" + line +
+            ", column=" + column +
+            '}';
+    }
 }

gherkin-vintage/src/test/java/io/cucumber/core/gherkin/vintage/FeatureParserTest.java

@@ -19,6 +19,21 @@
 class FeatureParserTest {
 
     private final GherkinVintageFeatureParser parser = new GherkinVintageFeatureParser();
+    @Test
+    void can_parse_single_scenario() throws IOException {
+        URI uri = URI.create("classpath:com/example.feature");
+        String source = new String(readAllBytes(Paths.get("src/test/resources/io/cucumber/core/gherkin/vintage/single.feature")));
+        Optional<Feature> feature = parser.parse(uri, source, UUID::randomUUID);
+        assertEquals(1, feature.get().getPickles().size());
+    }
+
+    @Test
+    void background_elements_are_not_scenarios() throws IOException {
+        URI uri = URI.create("classpath:com/example.feature");
+        String source = new String(readAllBytes(Paths.get("src/test/resources/io/cucumber/core/gherkin/vintage/background.feature")));
+        Optional<Feature> feature = parser.parse(uri, source, UUID::randomUUID);
+        assertEquals(1, feature.get().getPickles().size());
+    }
 
     @Test
     void empty_feature_file_is_parsed_but_produces_no_feature() throws IOException {

gherkin-vintage/src/test/resources/io/cucumber/core/gherkin/vintage/background.feature

@@ -0,0 +1,8 @@
+Feature: A feature with a background
+
+  Background: A background
+    Given a single scenario
+
+  Scenario: A single scenario
+    When it is executed
+    Then nothing else happens

gherkin-vintage/src/test/resources/io/cucumber/core/gherkin/vintage/single.feature

@@ -0,0 +1,8 @@
+Feature: A feature with a background
+
+  Background: A background
+    Given a single scenario
+
+  Scenario: A single scenario
+    When it is executed
+    Then nothing else happens

junit-platform-engine/src/test/java/io/cucumber/junit/platform/engine/FeatureResolverTest.java

@@ -2,8 +2,6 @@
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import org.junit.platform.engine.ConfigurationParameters;
-import org.junit.platform.engine.EngineDiscoveryRequest;
 import org.junit.platform.engine.TestDescriptor;
 import org.junit.platform.engine.TestTag;
 import org.junit.platform.engine.UniqueId;