Skip to content

Commit f0758b6

Browse files
mlvandijkmpkorstanje
authored andcommitted
Fix Test failure HTMLFormatterTest#writes_valid_report_js #729 (#1218)
Fixes #729
1 parent a3f847b commit f0758b6

File tree

1 file changed

+32
-12
lines changed

1 file changed

+32
-12
lines changed

core/src/test/java/cucumber/runtime/formatter/HTMLFormatterTest.java

+32-12
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
import org.jsoup.nodes.Element;
1313
import org.junit.Test;
1414
import org.mockito.stubbing.Answer;
15-
import org.mozilla.javascript.Context;
16-
import org.mozilla.javascript.EcmaError;
17-
import org.mozilla.javascript.tools.shell.Global;
1815

1916
import java.io.File;
2017
import java.io.InputStreamReader;
@@ -61,15 +58,38 @@ public void writes_index_html() throws Throwable {
6158
@Test
6259
public void writes_valid_report_js() throws Throwable {
6360
writeReport();
64-
URL reportJs = new URL(outputDir, "report.js");
65-
Context cx = Context.enter();
66-
Global scope = new Global(cx);
67-
try {
68-
cx.evaluateReader(scope, new InputStreamReader(reportJs.openStream(), "UTF-8"), reportJs.getFile(), 1, null);
69-
fail("Should have failed");
70-
} catch (EcmaError expected) {
71-
assertTrue(expected.getMessage().startsWith("ReferenceError: \"document\" is not defined."));
72-
}
61+
String reportJs = FixJava.readReader(new InputStreamReader(new URL(outputDir, "report.js").openStream(), "UTF-8"));
62+
assertEquals("$(document).ready(function() {var formatter = new CucumberHTML.DOMFormatter($('.cucumber-report'));formatter.uri(\"some\\\\windows\\\\path\\\\some.feature\");\n" +
63+
"formatter.feature({\n" +
64+
" \"name\": \"\",\n" +
65+
" \"description\": \"\",\n" +
66+
" \"keyword\": \"Feature\"\n" +
67+
"});\n" +
68+
"formatter.scenario({\n" +
69+
" \"name\": \"some cukes\",\n" +
70+
" \"description\": \"\",\n" +
71+
" \"keyword\": \"Scenario\"\n" +
72+
"});\n" +
73+
"formatter.step({\n" +
74+
" \"name\": \"first step\",\n" +
75+
" \"keyword\": \"Given \"\n" +
76+
"});\n" +
77+
"formatter.match({\n" +
78+
" \"location\": \"path/step_definitions.java:3\"\n" +
79+
"});\n" +
80+
"formatter.result({\n" +
81+
" \"status\": \"passed\"\n" +
82+
"});\n" +
83+
"formatter.embedding(\"image/png\", \"embedded0.png\");\n" +
84+
"formatter.after({\n" +
85+
" \"status\": \"passed\"\n" +
86+
"});\n" +
87+
"formatter.embedding(\"text/plain\", \"dodgy stack trace here\");\n" +
88+
"formatter.after({\n" +
89+
" \"status\": \"passed\"\n" +
90+
"});\n" +
91+
"});",
92+
reportJs);
7393
}
7494

7595
@Test

0 commit comments

Comments
 (0)