Skip to content

Commit fa2d198

Browse files
committed
[Build] Supress revapi findings
1 parent 38ef9af commit fa2d198

File tree

3 files changed

+6
-33
lines changed

3 files changed

+6
-33
lines changed

compatibility/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<modelVersion>4.0.0</modelVersion>
99

1010
<artifactId>cucumber-compatibility</artifactId>
11-
<name>Cucumber JVM: Compatibility Kit</name>
11+
<name>Cucumber-JVM: Compatibility Kit</name>
1212

1313
<dependencies>
1414

core/pom.xml

-28
Original file line numberDiff line numberDiff line change
@@ -137,34 +137,6 @@
137137
</archive>
138138
</configuration>
139139
</plugin>
140-
141-
<plugin>
142-
<groupId>org.apache.maven.plugins</groupId>
143-
<artifactId>maven-shade-plugin</artifactId>
144-
<executions>
145-
<execution>
146-
<phase>package</phase>
147-
<goals>
148-
<goal>shade</goal>
149-
</goals>
150-
<configuration>
151-
<artifactSet>
152-
<includes>
153-
<include>io.cucumber:gherkin</include>
154-
<include>io.cucumber:gherkin-jvm-deps</include>
155-
</includes>
156-
</artifactSet>
157-
<relocations>
158-
<relocation>
159-
<pattern>gherkin</pattern>
160-
<shadedPattern>io.cucumber.core.internal.gherkin</shadedPattern>
161-
</relocation>
162-
</relocations>
163-
</configuration>
164-
</execution>
165-
</executions>
166-
</plugin>
167-
168140
</plugins>
169141
</build>
170142

pom.xml

+5-4
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,7 @@
526526
</dependency>
527527
</dependencies>
528528
<configuration>
529+
<oldVersion>5.6.0</oldVersion>
529530
<analysisConfiguration>
530531
<revapi.semver.ignore>
531532
<enabled>true</enabled>
@@ -536,11 +537,11 @@
536537
</versionIncreaseAllows>
537538
</revapi.semver.ignore>
538539
<revapi.ignore>
540+
<!-- Cucumber-JUnit -->
539541
<item>
540-
<code>java.method.returnTypeChanged</code>
541-
<old><![CDATA[method java.util.Optional<io.cucumber.core.gherkin.Pickle> io.cucumber.core.gherkin.Feature::getPickleAt(io.cucumber.core.gherkin.Located)]]></old>
542-
<new><![CDATA[method io.cucumber.core.gherkin.Pickle io.cucumber.core.gherkin.Feature::getPickleAt(io.cucumber.core.gherkin.Located)]]></new>
543-
<justification>Internal API</justification>
542+
<code>java.class.externalClassExposedInAPI</code>
543+
<newArchive>junit:junit:jar:${junit.version}</newArchive>
544+
<justification>Implements JUnit4 API</justification>
544545
</item>
545546
<!-- Gherkin parser related -->
546547
<item>

0 commit comments

Comments
 (0)