Predictable iteration order for keys in DataTable.asMap(). Closes #764.

Author: aslakhellesoy

History.md

@@ -1,5 +1,6 @@
 ## [1.2.0-SNAPSHOT (Git master)](https://github.com/cucumber/cucumber-jvm/compare/v1.1.8...master) (Not released)
 
+* [Core] `DataTable.asMap()` returns a `LinkedHashMap`, ensuring key iteration order is the same as in the gherkin table ([#764](https://github.com/cucumber/cucumber-jvm/issues/764) Aslak Hellesøy).
 * [Core] Spring dirty cukes test fix ([#708](https://github.com/cucumber/cucumber-jvm/pull/708) Mykola Gurov)
 * [Core] Improve error message for multiple formatters using STDOUT ([#744](https://github.com/cucumber/cucumber-jvm/pull/744) Björn Rasmusson)
 * [Core] Better error messages when loading features from rerun file ([#749](https://github.com/cucumber/cucumber-jvm/pull/749) Björn Rasmusson)

core/src/main/java/cucumber/runtime/table/TableConverter.java

@@ -7,8 +7,6 @@
 import cucumber.deps.com.thoughtworks.xstream.io.HierarchicalStreamReader;
 import cucumber.runtime.CucumberException;
 import cucumber.runtime.ParameterInfo;
-import cucumber.runtime.table.CamelCaseStringConverter;
-import cucumber.runtime.table.StringConverter;
 import cucumber.runtime.xstream.CellWriter;
 import cucumber.runtime.xstream.ComplexTypeWriter;
 import cucumber.runtime.xstream.ListOfComplexTypeReader;
@@ -22,7 +20,7 @@
 import java.lang.reflect.Type;
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -175,7 +173,7 @@ public <K, V> Map<K, V> toMap(DataTable dataTable, Type keyType, Type valueType)
                 throw new CucumberException(String.format("Can't convert DataTable to Map<%s,%s>", keyType, valueType));
             }
 
-            Map<K, V> result = new HashMap<K, V>();
+            Map<K, V> result = new LinkedHashMap<K, V>();
             for (List<String> row : dataTable.raw()) {
                 if (row.size() != 2) {
                     throw new CucumberException("A DataTable can only be converted to a Map when there are 2 columns");
@@ -208,7 +206,7 @@ public <K, V> List<Map<K, V>> toMaps(DataTable dataTable, Type keyType, Type val
             }
             List<List<String>> valueRows = dataTable.cells(1);
             for (List<String> valueRow : valueRows) {
-                Map<K, V> map = new HashMap<K, V>();
+                Map<K, V> map = new LinkedHashMap<K, V>();
                 int i = 0;
                 for (String cell : valueRow) {
                     map.put(keys.get(i), (V) valueConverter.fromString(cell));