fix: applied checkstyle on test classes for #2767

Author: Julien Kronegg

cucumber-archetype/src/main/resources/archetype-resources/src/test/java/StepDefinitions.java

@@ -1,8 +1,8 @@
 package ${package};
 
-import io.cucumber.java.en.*;
-
-import org.junit.jupiter.api.Assertions.*;
+import io.cucumber.java.en.Given;
+import io.cucumber.java.en.Then;
+import io.cucumber.java.en.When;
 
 public class StepDefinitions {
 

cucumber-archetype/src/test/resources/projects/should-generate-project/reference/src/test/java/com/example/StepDefinitions.java

@@ -1,8 +1,8 @@
 package com.example;
 
-import io.cucumber.java.en.*;
-
-import org.junit.jupiter.api.Assertions.*;
+import io.cucumber.java.en.Given;
+import io.cucumber.java.en.Then;
+import io.cucumber.java.en.When;
 
 public class StepDefinitions {
 

cucumber-core/src/test/java/io/cucumber/core/backend/StubPendingException.java

@@ -1,7 +1,5 @@
 package io.cucumber.core.backend;
 
-import io.cucumber.core.backend.Pending;
-
 import java.io.PrintStream;
 import java.io.PrintWriter;
 

cucumber-core/src/test/java/io/cucumber/core/eventbus/RandomUuidGeneratorTest.java

@@ -4,7 +4,8 @@
 
 import java.util.UUID;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 class RandomUuidGeneratorTest {
     @Test

cucumber-core/src/test/java/io/cucumber/core/exception/UnrecoverableExceptionsTest.java

@@ -3,7 +3,8 @@
 import org.junit.jupiter.api.Test;
 
 import static io.cucumber.core.exception.UnrecoverableExceptions.rethrowIfUnrecoverable;
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 class UnrecoverableExceptionsTest {
 

cucumber-core/src/test/java/io/cucumber/core/options/RuntimeOptionsBuilderTest.java

@@ -3,7 +3,7 @@
 import io.cucumber.core.eventbus.IncrementingUuidGenerator;
 import org.junit.jupiter.api.Test;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 class RuntimeOptionsBuilderTest {
 

cucumber-core/src/test/java/io/cucumber/core/options/UuidGeneratorParserTest.java

@@ -7,7 +7,8 @@
 import org.junit.jupiter.api.Test;
 
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 class UuidGeneratorParserTest {
 

cucumber-core/src/test/java/io/cucumber/core/plugin/CanonicalEventOrderTest.java

@@ -6,7 +6,6 @@
 import io.cucumber.plugin.event.SnippetsSuggestedEvent;
 import io.cucumber.plugin.event.SnippetsSuggestedEvent.Suggestion;
 import io.cucumber.plugin.event.Status;
-import io.cucumber.plugin.event.TestCase;
 import io.cucumber.plugin.event.TestCaseStarted;
 import io.cucumber.plugin.event.TestRunFinished;
 import io.cucumber.plugin.event.TestRunStarted;

cucumber-core/src/test/java/io/cucumber/core/plugin/PluginFactoryTest.java

@@ -8,7 +8,13 @@
 import io.cucumber.messages.types.Envelope;
 import io.cucumber.plugin.ConcurrentEventListener;
 import io.cucumber.plugin.EventListener;
-import io.cucumber.plugin.event.*;
+import io.cucumber.plugin.event.EventHandler;
+import io.cucumber.plugin.event.EventPublisher;
+import io.cucumber.plugin.event.Result;
+import io.cucumber.plugin.event.Status;
+import io.cucumber.plugin.event.TestRunFinished;
+import io.cucumber.plugin.event.TestRunStarted;
+import io.cucumber.plugin.event.TestStepFinished;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.function.Executable;

cucumber-core/src/test/java/io/cucumber/core/plugin/PluginsTest.java

@@ -15,7 +15,12 @@
 import java.util.List;
 import java.util.Map;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertIterableEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class PluginsTest {
 

cucumber-core/src/test/java/io/cucumber/core/plugin/ProgressFormatterTest.java

@@ -2,7 +2,16 @@
 
 import io.cucumber.core.eventbus.EventBus;
 import io.cucumber.core.runtime.TimeServiceEventBus;
-import io.cucumber.plugin.event.*;
+import io.cucumber.plugin.event.Argument;
+import io.cucumber.plugin.event.Location;
+import io.cucumber.plugin.event.PickleStepTestStep;
+import io.cucumber.plugin.event.Result;
+import io.cucumber.plugin.event.Step;
+import io.cucumber.plugin.event.StepArgument;
+import io.cucumber.plugin.event.TestCase;
+import io.cucumber.plugin.event.TestRunFinished;
+import io.cucumber.plugin.event.TestStep;
+import io.cucumber.plugin.event.TestStepFinished;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 

cucumber-core/src/test/java/io/cucumber/core/plugin/UnusedStepsSummaryPrinterTest.java

@@ -1,7 +1,13 @@
 package io.cucumber.core.plugin;
 
 import io.cucumber.core.runtime.TimeServiceEventBus;
-import io.cucumber.plugin.event.*;
+import io.cucumber.plugin.event.Result;
+import io.cucumber.plugin.event.Status;
+import io.cucumber.plugin.event.StepDefinedEvent;
+import io.cucumber.plugin.event.StepDefinition;
+import io.cucumber.plugin.event.TestRunFinished;
+import io.cucumber.plugin.event.TestStep;
+import io.cucumber.plugin.event.TestStepFinished;
 import org.junit.jupiter.api.Test;
 
 import java.io.ByteArrayOutputStream;

cucumber-core/src/test/java/io/cucumber/core/plugin/UsageFormatterTest.java

@@ -1,6 +1,10 @@
 package io.cucumber.core.plugin;
 
-import io.cucumber.plugin.event.*;
+import io.cucumber.plugin.event.PickleStepTestStep;
+import io.cucumber.plugin.event.Result;
+import io.cucumber.plugin.event.Status;
+import io.cucumber.plugin.event.TestStep;
+import io.cucumber.plugin.event.TestStepFinished;
 import org.json.JSONException;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;

cucumber-core/src/test/java/io/cucumber/core/runner/CachingGlueTest.java

@@ -1,6 +1,18 @@
 package io.cucumber.core.runner;
 
-import io.cucumber.core.backend.*;
+import io.cucumber.core.backend.CucumberBackendException;
+import io.cucumber.core.backend.CucumberInvocationTargetException;
+import io.cucumber.core.backend.DataTableTypeDefinition;
+import io.cucumber.core.backend.DefaultDataTableCellTransformerDefinition;
+import io.cucumber.core.backend.DefaultDataTableEntryTransformerDefinition;
+import io.cucumber.core.backend.DefaultParameterTransformerDefinition;
+import io.cucumber.core.backend.DocStringTypeDefinition;
+import io.cucumber.core.backend.HookDefinition;
+import io.cucumber.core.backend.ParameterInfo;
+import io.cucumber.core.backend.ParameterTypeDefinition;
+import io.cucumber.core.backend.ScenarioScoped;
+import io.cucumber.core.backend.SourceReference;
+import io.cucumber.core.backend.StepDefinition;
 import io.cucumber.core.backend.TestCaseState;
 import io.cucumber.core.eventbus.EventBus;
 import io.cucumber.core.feature.TestFeatureParser;
@@ -22,7 +34,11 @@
 import java.lang.reflect.Type;
 import java.net.URI;
 import java.time.Clock;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.UUID;
 import java.util.stream.Collectors;
 
 import static java.util.Locale.ENGLISH;
@@ -31,7 +47,11 @@
 import static org.hamcrest.collection.IsIterableContainingInOrder.contains;
 import static org.hamcrest.core.Is.is;
 import static org.hamcrest.core.IsEqual.equalTo;
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertAll;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class CachingGlueTest {
 

cucumber-core/src/test/java/io/cucumber/core/runner/HookTestStepTest.java

@@ -20,8 +20,6 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.core.Is.is;
 import static org.hamcrest.core.IsEqual.equalTo;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.ArgumentMatchers.isA;
 import static org.mockito.Mockito.inOrder;
 import static org.mockito.Mockito.mock;

cucumber-core/src/test/java/io/cucumber/core/runner/PickleStepTestStepTest.java

@@ -38,8 +38,6 @@
 import static org.hamcrest.core.Is.is;
 import static org.hamcrest.core.IsEqual.equalTo;
 import static org.junit.jupiter.api.Assertions.assertAll;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.ArgumentCaptor.forClass;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.argThat;

cucumber-core/src/test/java/io/cucumber/core/runner/TestCaseStateResultTest.java

@@ -3,12 +3,19 @@
 import io.cucumber.core.eventbus.EventBus;
 import io.cucumber.core.feature.TestFeatureParser;
 import io.cucumber.core.gherkin.Feature;
-import io.cucumber.plugin.event.*;
+import io.cucumber.plugin.event.EmbedEvent;
+import io.cucumber.plugin.event.EventHandler;
+import io.cucumber.plugin.event.Result;
+import io.cucumber.plugin.event.Status;
+import io.cucumber.plugin.event.WriteEvent;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import java.time.Instant;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.UUID;
 
 import static io.cucumber.core.backend.Status.FAILED;
 import static io.cucumber.core.backend.Status.PASSED;
@@ -19,7 +26,11 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.core.Is.is;
 import static org.hamcrest.core.IsEqual.equalTo;
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertAll;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class TestCaseStateResultTest {
 

cucumber-core/src/test/java/io/cucumber/core/runner/TestCaseTest.java

@@ -1,13 +1,20 @@
 package io.cucumber.core.runner;
 
-import io.cucumber.core.backend.*;
+import io.cucumber.core.backend.CucumberBackendException;
+import io.cucumber.core.backend.CucumberInvocationTargetException;
+import io.cucumber.core.backend.HookDefinition;
+import io.cucumber.core.backend.ParameterInfo;
 import io.cucumber.core.backend.StepDefinition;
 import io.cucumber.core.eventbus.EventBus;
 import io.cucumber.core.feature.TestFeatureParser;
 import io.cucumber.core.gherkin.Feature;
 import io.cucumber.core.gherkin.Pickle;
-import io.cucumber.plugin.event.*;
+import io.cucumber.plugin.event.EventHandler;
 import io.cucumber.plugin.event.Status;
+import io.cucumber.plugin.event.TestCaseFinished;
+import io.cucumber.plugin.event.TestCaseStarted;
+import io.cucumber.plugin.event.TestStepFinished;
+import io.cucumber.plugin.event.TestStepStarted;
 import org.junit.jupiter.api.Test;
 
 import java.net.URI;
@@ -22,7 +29,7 @@
 import static io.cucumber.plugin.event.HookType.BEFORE_STEP;
 import static java.util.Arrays.asList;
 import static java.util.Collections.singletonList;
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 
 class TestCaseTest {
     private final Feature feature = TestFeatureParser.parse("" +

cucumber-core/src/test/java/io/cucumber/core/runner/ThrowableCollectorTest.java

@@ -3,7 +3,9 @@
 import org.junit.jupiter.api.Test;
 import org.opentest4j.TestAbortedException;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 class ThrowableCollectorTest {
 

cucumber-core/src/test/java/io/cucumber/core/runtime/CucumberExecutionContextTest.java

@@ -4,7 +4,11 @@
 import io.cucumber.core.options.RuntimeOptions;
 import io.cucumber.core.options.RuntimeOptionsBuilder;
 import io.cucumber.core.plugin.StubTestCase;
-import io.cucumber.plugin.event.*;
+import io.cucumber.plugin.event.Result;
+import io.cucumber.plugin.event.Status;
+import io.cucumber.plugin.event.TestCaseFinished;
+import io.cucumber.plugin.event.TestRunFinished;
+import io.cucumber.plugin.event.TestRunStarted;
 import org.junit.jupiter.api.Test;
 
 import java.time.Clock;
@@ -38,7 +42,7 @@ class CucumberExecutionContextTest {
     private final CucumberExecutionContext context = new CucumberExecutionContext(bus, exitStatus, runnerSupplier);
 
     @Test
-    public void collects_and_rethrows_failures_in_runner() {
+    void collects_and_rethrows_failures_in_runner() {
         IllegalStateException thrown = assertThrows(IllegalStateException.class, () -> context.runTestCase(runner -> {
             throw failure;
         }));
@@ -47,7 +51,7 @@ public void collects_and_rethrows_failures_in_runner() {
     }
 
     @Test
-    public void rethrows_but_does_not_collect_failures_in_test_case() {
+    void rethrows_but_does_not_collect_failures_in_test_case() {
         IllegalStateException thrown = assertThrows(IllegalStateException.class, () -> context.runTestCase(runner -> {
             try (TestCaseResultObserver r = new TestCaseResultObserver(bus)) {
                 bus.send(new TestCaseFinished(bus.getInstant(), new StubTestCase(),
@@ -64,7 +68,7 @@ public void rethrows_but_does_not_collect_failures_in_test_case() {
     }
 
     @Test
-    public void emits_failures_in_events() {
+    void emits_failures_in_events() {
         List<TestRunStarted> testRunStarted = new ArrayList<>();
         List<TestRunFinished> testRunFinished = new ArrayList<>();
 

cucumber-core/src/test/java/io/cucumber/core/runtime/ObjectFactoryServiceLoaderTest.java

@@ -3,12 +3,7 @@
 import io.cucumber.core.backend.DefaultObjectFactory;
 import io.cucumber.core.backend.ObjectFactory;
 import io.cucumber.core.backend.Options;
-import io.cucumber.core.eventbus.IncrementingUuidGenerator;
-import io.cucumber.core.eventbus.RandomUuidGenerator;
-import io.cucumber.core.eventbus.UuidGenerator;
 import io.cucumber.core.exception.CucumberException;
-import org.hamcrest.Matchers;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import java.util.function.Supplier;

cucumber-core/src/test/java/io/cucumber/core/runtime/RuntimeTest.java

@@ -1,6 +1,12 @@
 package io.cucumber.core.runtime;
 
-import io.cucumber.core.backend.*;
+import io.cucumber.core.backend.CucumberBackendException;
+import io.cucumber.core.backend.Glue;
+import io.cucumber.core.backend.HookDefinition;
+import io.cucumber.core.backend.ParameterInfo;
+import io.cucumber.core.backend.ScenarioScoped;
+import io.cucumber.core.backend.StaticHookDefinition;
+import io.cucumber.core.backend.TestCaseState;
 import io.cucumber.core.eventbus.EventBus;
 import io.cucumber.core.exception.CompositeCucumberException;
 import io.cucumber.core.exception.CucumberException;

cucumber-core/src/test/java/io/cucumber/core/runtime/ServiceLoaderTestClassLoader.java

@@ -14,15 +14,15 @@
 
 /**
  * Testing classloader for ServiceLoader. This classloader overrides the
- * META-INF/services/<interface> file with a custom definition.
+ * META-INF/services/&lt;interface&gt; file with a custom definition.
  */
 public class ServiceLoaderTestClassLoader extends URLClassLoader {
     Class<?> metaInfInterface;
     Class<?>[] implementingClasses;
 
     /**
      * Constructs a classloader which has no
-     * META-INF/services/<metaInfInterface>.
+     * META-INF/services/&lt;metaInfInterface&gt;.
      *
      * @param metaInfInterface ServiceLoader interface
      */
@@ -31,7 +31,7 @@ public ServiceLoaderTestClassLoader(Class<?> metaInfInterface) {
     }
 
     /**
-     * Constructs a fake META-INF/services/<metaInfInterface> file which
+     * Constructs a fake META-INF/services/&lt;metaInfInterface&gt; file which
      * contains the provided array of classes. When the implementingClasses
      * array is null, the META-INF file will not be constructed. The classes
      * from implementingClasses are not required to implement the