Skip to content

[Core] Use Gherkin 6+ and Cucumber messages #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 132 commits into from
Mar 19, 2020
Merged

[Core] Use Gherkin 6+ and Cucumber messages #1841

merged 132 commits into from
Mar 19, 2020

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Dec 13, 2019

Summary

  • Implements the message formatter which will output cucumber messages as ndjson as well as an improved html formatter which renders a html report based on these messages.

  • Switches the default parser to Gherkin 6+. This will enable rule support by default.

  • The json formatter has been made optional and has been moved to gherkin-vintage. It does not support rules and will throw an exception when rules are used.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

coveralls commented Feb 28, 2020

Coverage Status

Coverage increased (+1.5%) to 84.541% when pulling c50393c on gherkin8 into 4d98e02 on master.

@mpkorstanje
Copy link
Contributor Author

Consideration: Add some maven checks to the build to ensure dependency convergence. We currently have allot of dependencies and transitive dependencies on messages. These should all be in sync. While the protobuf itself is forwards and backwards compatible, the bytecode is decidedly not.

@mpkorstanje mpkorstanje changed the base branch from master to v6.x.x March 14, 2020 13:36
@mpkorstanje mpkorstanje changed the title Gherkin Message Formatter [Core] Upgrade Gherkin to use Cucumber message protocol Mar 19, 2020
@mpkorstanje mpkorstanje changed the title [Core] Upgrade Gherkin to use Cucumber message protocol [Core] Use Gherkin 6+ and Cucumber messages Mar 19, 2020
@mpkorstanje mpkorstanje marked this pull request as ready for review March 19, 2020 12:17
@mpkorstanje mpkorstanje merged commit d3b5472 into v6.x.x Mar 19, 2020
@mpkorstanje mpkorstanje deleted the gherkin8 branch March 26, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants