[Core] cucumber.feature preserves tags when used with a feature argument #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
changed the title
cucumber.feature preserves tags when used with a feature argumentThe feature option can be used with either a rerun file or a feature path. For example when used as a property: ``` cucumber.feature=path/to/features cucumber.feature=@path/to/rerun.txt ``` Cucumber options consist of a hierarchy of options. When the feature options is used with a rerun file; tag and name filters from the previous level should be removed. This ensures that all scenarios in the rerun file and only the scenarios in the rerun file should be executed (unless the selection is filtered more at this or the next level). When used with a feature argument without a line filter this should not be the case. However `builder::addRerun` would be invoked anyway. When parsing `cucumber.feature` for rerun files, when no rerun files are present an empty collection is returned. Because `splitAndMap` was used rather then `splitAndThenFlatMap`, `builder::addRerun` would always be invoked. Fixes: #1985
mpkorstanje
force-pushed
the
core-do-not-clobber-tags-on-feature-argument
branch
from
2e75dcf to
7965517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature option can be used with either a rerun file or a feature path. For
example when used as a property:
Cucumber options consist of a hierarchy of options. When the feature options is
used with a rerun file; tag and name filters from the previous level should be
removed. This ensures that all scenarios in the rerun file and only the
scenarios in the rerun file should be executed (unless the selection is filtered
more at this or the next level).
When used with a feature argument without a line filter this should not be the case.
However
builder::addRerunwould be invoked anyway.When parsing
cucumber.featurefor rerun files, when no rerun files are present anempty collection is returned. Because
splitAndMapwas used rather thensplitAndThenFlatMap,builder::addRerunwould always be invoked.Fixes: #1985