[JUnit] Make duplicate pickle names unique

[mpkorstanje]

Individual examples do not have a unique name. And while a unique name is not
required by Junit, various integrations such as sbt-junit assume this the case.

By appending [#n] to a scenario name it becomes unique again. So JUnit 4s
output becomes:

A feature with scenario outlines
  A scenario outline #1
  A scenario outline #2
  A scenario outline #3
  A scenario outline #4

The #n was taken from JUnit 5 which renders examples as:

A feature with scenario outlines
  A scenario outline
    With some other text
      Example #1
      Example #2
    With some text
     Example #1
     Example #2

Fixes: cucumber/cucumber-jvm-scala#102

[coveralls]

Coverage increased (+0.03%) to 86.23% when pulling f7707a1 on fix-102-make-pickle-names-unique into b2c3b0e on main.

[gaeljw]

I tested it in the context of sbt junit, it seems to work but the error is not very self explanatory:

[error] Test bdd.tests.XxxTest.initializationError failed: java.lang.NullPointerException: null, took 0.017 sec
[error]     at io.cucumber.junit.FileNameCompatibleNames.uniqueSuffix(FileNameCompatibleNames.java:29)
[error]     at io.cucumber.junit.FeatureRunner.lambda$new$0(FeatureRunner.java:52)

[mpkorstanje]

It's not supposed to throw an error. :D

[mpkorstanje]

@gaeljw found the problem. I moved the filter into the wrong stream.

[rhande-mdsol]

Hello @mpkorstanje Thanks for looking into this. Are you planning to release this change ?

[mpkorstanje]

After you tell me that it fixes the problem. 😄

[rhande-mdsol]

Sorry @mpkorstanje I am still trying to publish this project / PR and use it in my application, as I never worked on Maven before. Apologies

Is there a way that I can download the dependency of this particular PR and test ? I mean just like how it downloads from maven repository ?

[gaeljw]

Works perfectly for me in the two cases:

• "Regular" scenarios with same name
• Scenario Outlines

Great work @mpkorstanje