Skip to content

Remove DeltaSpike #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpkorstanje opened this issue Nov 27, 2022 · 3 comments · Fixed by #2674
Closed

Remove DeltaSpike #2650

mpkorstanje opened this issue Nov 27, 2022 · 3 comments · Fixed by #2674
Labels
🏦 debt Tech debt
Milestone

Comments

@mpkorstanje
Copy link
Contributor

👓 What did you see?

When building cucumber-jvm with Java 17 using mvn clean install:

Exception 0 :
org.jboss.weld.exceptions.WeldException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @62bd2070
        at org.jboss.weld.bean.proxy.ProxyFactory.getProxyClass(ProxyFactory.java:294)
        at org.jboss.weld.bean.proxy.ProxyFactory.create(ProxyFactory.java:248)

Upgrading Weld to the latest supported by deltaspike-cdictrl-api results in:

Nov 27, 2022 7:04:28 PM org.jboss.weld.bootstrap.WeldStartup <clinit>
INFO: WELD-000900: 3.1.3 (Final)

java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int) throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @704d6e83

	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
	at java.base/java.lang.reflect.Method.checkCanSetAccessible(Method.java:199)
	at java.base/java.lang.reflect.Method.setAccessible(Method.java:193)
	at org.jboss.weld.util.bytecode.ClassFileUtils$1.run(ClassFileUtils.java:88)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:569)
	at org.jboss.weld.util.bytecode.ClassFileUtils.makeClassLoaderMethodsAccessible(ClassFileUtils.java:64)

📚 Any additional context?

This is currently blocking the use of Java 17 to build the project which is required for #2644.

@mpkorstanje mpkorstanje added the 🏦 debt Tech debt label Nov 27, 2022
@mpkorstanje
Copy link
Contributor Author

@toepi you once contributed this implementation in #1616. Can you confirm that there currently is no viable way to use DeltaSpike on Java 17?

@mpkorstanje
Copy link
Contributor Author

mpkorstanje commented Dec 11, 2022

Decided to deprecate Delta Spike. Will be removed in v8.

@mpkorstanje mpkorstanje changed the title Deltaspike fails to build on Java 17 Remove DeltaSpike Dec 11, 2022
@mpkorstanje mpkorstanje added this to the v8.0.0 milestone Dec 11, 2022
@mpkorstanje mpkorstanje reopened this Dec 11, 2022
@mpkorstanje mpkorstanje modified the milestones: v8.0.0, v7.x.x Jan 6, 2023
@mpkorstanje
Copy link
Contributor Author

mpkorstanje commented Jan 6, 2023

Looks like it can be made to work. It was mostly the tests that needed updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant