java: Optimize Location #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separating out the elements from #372 that involve Location * Replaced `io.cucumber.gherkin.Location` with `io.cucumber.messages.types.Location` to reduce creation of temporary objects. * Ensure `Token.location` is non-null. * `Location` instances are created through `Locations` utility allowing for reuse of `Long` objects. * Pre-create `Long` objects for 0 through 4000 to avoid churn while parsing. Fixes: #384
jkronegg
pushed a commit
that referenced
this pull request
Apr 2, 2025
jkronegg
pushed a commit
that referenced
this pull request
Apr 2, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Separating out the elements from #372 that involve Location
Replaced
io.cucumber.gherkin.Locationwithio.cucumber.messages.types.Locationto reduce creation of temporary objects.Ensure
Token.locationis non-null.Locationinstances are created throughLocationsutility allowing for reuse ofLongobjects.Pre-create
Longobjects for 0 through 4000 to avoid churn while parsing.⚡️ What's your motivation?
Fixes: cucumber/cucumber-jvm#2985
🏷️ What kind of change is this?
📋 Checklist: