Skip to content

Switch to use logback? #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhajratw opened this issue Mar 20, 2014 · 4 comments
Closed

Switch to use logback? #693

nhajratw opened this issue Mar 20, 2014 · 4 comments

Comments

@nhajratw
Copy link
Contributor

Is there any interest in changing the code to use logback rather than log4j?

http://logback.qos.ch/reasonsToSwitch.html

If so, I'm happy to take a crack at it.

@aslakhellesoy
Copy link
Contributor

I thought log4j was just a transitive dependency? I don't remember what parts of the code uses it. None that I have written - maybe some of the enterprisey stuff (openejb, spring..)

@nhajratw
Copy link
Contributor Author

It's transitive through cobertura, It also seems like it's used in the spring-txn examples and needle tests

[nayan@endor:~/Documents/workspace/cucumber-jvm (master)] ➔ git grep log4j
History.md:* [OpenEJB] Remove log4j need for openejb module (#355 rmannibucau)
examples/spring-txn/pom.xml: slf4j-log4j12
examples/spring-txn/pom.xml: log4j
examples/spring-txn/pom.xml: log4j
examples/spring-txn/src/main/resources/log4j.properties:log4j.rootLogger=INFO,CONSOLE
examples/spring-txn/src/main/resources/log4j.properties:log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender
examples/spring-txn/src/main/resources/log4j.properties:log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout
examples/spring-txn/src/main/resources/log4j.properties:log4j.appender.CONSOLE.layout.ConversionPattern=%-5p: %c - %m%n
needle/pom.xml: slf4j-log4j12
needle/pom.xml: log4j
needle/pom.xml: log4j
needle/src/test/resources/log4j.properties:log4j.rootLogger = ERROR, ROOTLOGGER
needle/src/test/resources/log4j.properties:log4j.appender.ROOTLOGGER = org.apache.log4j.ConsoleAppender
needle/src/test/resources/log4j.properties:log4j.appender.ROOTLOGGER.layout = org.apache.log4j.PatternLayout
needle/src/test/resources/log4j.properties:log4j.appender.ROOTLOGGER.layout.ConversionPattern = %d{HH:mm:ss,SSS} %-5p [%t] %c{3} %3x - %m%n
needle/src/test/resources/log4j.properties:#log4j.logger.cucumber = ERROR
needle/src/test/resources/log4j.properties:#log4j.logger.de.akquinet.jbosscc.needle = ERROR
pom.xml: <log4j.version>1.2.17</log4j.version>
pom.xml: slf4j-log4j12
pom.xml: log4j
pom.xml: log4j
pom.xml: ${log4j.version}

@nhajratw
Copy link
Contributor Author

ugh -- forgot this was out here, i created a new pull request for it, so this is closed. #696

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants