@Before and @After hook order comparison susceptible to underflow

[auno]

If two @before hooks are created with a great enough difference (i.e. greater than 2^31), they may be executed in the incorrect order due to an arithmetic underflow in HookComparator.

[aslakhellesoy]

Why is this a problem? How many hooks do you have? Feel free to submit a fix if this is a problem for you.

[aslakhellesoy]

Just spotted the PR - thanks!

[auno]

You don't need that many. My scenario is that I have one @before hook that I want to always run first, so to guard against future bugs I give it order = Integer.MIN_VALUE. This combined with another @before hook with the default order of 10000 triggers this.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.