Skip to content

Commit 2797cfd

Browse files
aslakhellesoynddipiazzaNicholas DiPiazzajamietanna
authored
Nddipiazza address issue 1662 (#1985)
* some initial commits towards https://github.com/cucumber/common/issues/1662 * finish the Pretty document stuff. * add some gitignores * code formatting. * maven-itize the project do my best at trying to add the make and gherkin-ish stuff * add more of the other files * javadoc * add comments. * the formatting of numbers on the left side caused differences with intellij's auto formatter which is not good. fixed a couple other differences between IntelliJ's auto formatter fixed some comment formatting issues. * pr review * handle end of file comments. * fix broken test * fix ci issue * add entry for gherkin-util/java in ci config.yaml * try to fix config error * try to fix config error * try removing it * Revert "fix ci issue" This reverts commit a9a30cb01f60abb6ba572ed8a7f29705554bf936. * more fixes * fix typo in name * add commited files for ci * push untracked files * fix gherkin patch m2 * fix package names to match project * push source * fix remaining issues with make * push source * push untracked files * push untracked files * Update dependencies and refactor * Refactor * Limit API surface area * Add dependency on gherkin-java Co-authored-by: Nicholas DiPiazza <[email protected]> Co-authored-by: Nicholas DiPiazza <[email protected]> Co-authored-by: Nicholas DiPiazza <[email protected]> Co-authored-by: Jamie Tanna <[email protected]>
1 parent 0e45424 commit 2797cfd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

java/scripts/check-jar.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ set -uf -o pipefail
88
check_jar() {
99
jar="$1"
1010
module_name=$(xmlstarlet sel -N pom="http://maven.apache.org/POM/4.0.0" -t -m "//pom:project.Automatic-Module-Name" -v . pom.xml)
11-
module_path=$(echo $module_name | sed "s/\./\\\\\//g")
12-
echo "Checking contents of ${jar}"
11+
module_path=$(echo $module_name | sed "s/\./\\\\\//g" | sed "s/-/\\\\\//g")
12+
echo "Checking contents of ${jar} to see if it matches pattern: ${module_path}"
1313
unshaded_classes=$(unzip -l ${jar} | grep -e "\.class" | rev | cut -d' ' -f1 | rev | grep -v "^$module_path")
1414
if [[ "${unshaded_classes}" != "" ]]; then
15-
echo "Some classes in ${jar} are not in the io.cucumber package. Rename the classes or change the maven-shade-plugin configuration."
15+
echo "Some classes in ${jar} are not in the expected package matching pattern ${module_path}. Rename the classes or change the maven-shade-plugin configuration."
1616
echo
1717
echo "${unshaded_classes}"
1818
exit 1

0 commit comments

Comments
 (0)