Skip to content

Commit 2ca90b0

Browse files
authored
Prohibit wildcard import in pylint (#8893)
1 parent 3bc92da commit 2ca90b0

File tree

11 files changed

+24
-15
lines changed

11 files changed

+24
-15
lines changed

Diff for: .pylintrc

+2-2
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,6 @@ disable=raw-checker-failed,
287287
raise-missing-from,
288288
raising-format-tuple,
289289
wrong-exception-operation,
290-
wildcard-import,
291290
deprecated-module,
292291
import-self,
293292
preferred-module,
@@ -516,7 +515,8 @@ enable=singleton-comparison,
516515
logging-unsupported-format,
517516
logging-format-truncated,
518517
logging-too-many-args,
519-
logging-too-few-args
518+
logging-too-few-args,
519+
wildcard-import
520520

521521

522522
[BASIC]

Diff for: cvat-sdk/cvat_sdk/models.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
#
33
# SPDX-License-Identifier: MIT
44

5-
from cvat_sdk.api_client.models import * # pylint: disable=unused-import,redefined-builtin
5+
# Reexport symbols for public SDK API
6+
from cvat_sdk.api_client.models import * # pylint: disable=wildcard-import

Diff for: cvat/apps/engine/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
#
44
# SPDX-License-Identifier: MIT
55

6-
7-
from .schema import * # force import of declared symbols
6+
# Force execution of declared symbols
7+
from .schema import * # pylint: disable=wildcard-import

Diff for: cvat/settings/development.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
#
33
# SPDX-License-Identifier: MIT
44

5-
from .base import *
5+
# Inherit parent config
6+
from .base import * # pylint: disable=wildcard-import
67

78
# SECURITY WARNING: don't run with debug turned on in production!
89
DEBUG = True

Diff for: cvat/settings/email_settings.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
#
44
# SPDX-License-Identifier: MIT
55

6-
from cvat.settings.production import *
6+
# Inherit parent config
7+
from cvat.settings.production import * # pylint: disable=wildcard-import
78

89
# https://github.com/pennersr/django-allauth
910
ACCOUNT_AUTHENTICATION_METHOD = 'username_email'

Diff for: cvat/settings/production.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
#
33
# SPDX-License-Identifier: MIT
44

5-
from .base import *
5+
# Inherit parent config
6+
from .base import * # pylint: disable=wildcard-import
67

78
DEBUG = False
89

Diff for: cvat/settings/testing.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44

55
import tempfile
66

7-
from .development import *
7+
# Inherit parent config
8+
from .development import * # pylint: disable=wildcard-import
89

910
DATABASES = {
1011
'default': {

Diff for: cvat/settings/testing_rest.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
#
33
# SPDX-License-Identifier: MIT
44

5-
from cvat.settings.production import *
5+
# Inherit parent config
6+
from cvat.settings.production import * # pylint: disable=wildcard-import
67

78
# We use MD5 password hasher instead of default PBKDF2 here to speed up REST API tests,
89
# because the current implementation of the tests requires authentication in each test case

Diff for: tests/python/cli/conftest.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
#
33
# SPDX-License-Identifier: MIT
44

5-
from sdk.fixtures import * # pylint: disable=unused-import
5+
# Force execution of fixture definitions
6+
from sdk.fixtures import * # pylint: disable=wildcard-import

Diff for: tests/python/conftest.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#
33
# SPDX-License-Identifier: MIT
44

5-
from shared.fixtures.data import *
6-
from shared.fixtures.init import *
7-
from shared.fixtures.util import *
5+
# Force execution of fixture definitions
6+
from shared.fixtures.data import * # pylint: disable=wildcard-import
7+
from shared.fixtures.init import * # pylint: disable=wildcard-import
8+
from shared.fixtures.util import * # pylint: disable=wildcard-import

Diff for: tests/python/sdk/conftest.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
#
33
# SPDX-License-Identifier: MIT
44

5-
from .fixtures import *
5+
# Force execution of fixture definitions
6+
from .fixtures import * # pylint: disable=wildcard-import

0 commit comments

Comments
 (0)