This repository was archived by the owner on Oct 1, 2020. It is now read-only.
feat: Add Typescript types #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickBolles
added a commit
to NickBolles/cypress-nuxt
that referenced
this pull request
Apr 7, 2020
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
OliverJAsh
reviewed
Apr 7, 2020
| @@ -60,6 +62,7 @@ | |||
| "files": [ | |||
| "*.js" | |||
| ], | |||
| "types": "index.d.ts", | |||
There was a problem hiding this comment.
index.d.ts is not included in files, so it's not part of the npm package:
There was a problem hiding this comment.
D'oh! I'll get that fixed and a new release out right away.
There was a problem hiding this comment.
I could have sworn the types field was included by default. Main is, but types aren't I guess :(
https://docs.npmjs.com/files/package.json
Thanks @OliverJAsh and @chrisbreiding!
panzarino
pushed a commit
to cypress-io/cypress
that referenced
this pull request
Sep 17, 2020
* feat: typings * fix: revert cypress version change * make eslint plugin happy, but also don't lint types file * chore: update yarn.lock Co-authored-by: Chris Breiding <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67