Skip to content

Commit 9a0e9c9

Browse files
committed
Reduce port collision risks in triage scripts
1 parent 39354dc commit 9a0e9c9

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/services/welcome-message-service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export function showWelcomeMessage(context: vscode.ExtensionContext) {
2828
showMessageAndButtons(`
2929
DevDb updated to ${currentVersion}.
3030
✨ You can now support DevDb develpment
31-
Added support for custom workspace base bath
31+
Allow multiple connections of same type in .devdbrc
3232
✨ (see details in the repo's README)
3333
`, context);
3434
}

triage/mssql-triage.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ if [ "$(docker ps -a --filter 'name=^/mssql-devdb-triage$' --format '{{.Names}}'
99
docker start mssql-devdb-triage
1010
else
1111
echo "Container does not exist. Creating a new mssql-devdb-triage container..."
12-
docker run --name mssql-devdb-triage -e 'ACCEPT_EULA=Y' -e 'SA_PASSWORD=MyS3cretPassw0rd' -p 1433:1433 -d mcr.microsoft.com/mssql/server:2019-latest
12+
docker run --name mssql-devdb-triage -e 'ACCEPT_EULA=Y' -e 'SA_PASSWORD=MyS3cretPassw0rd' -p 1111:1433 -d mcr.microsoft.com/mssql/server:2019-latest
1313
fi
1414

1515
# Install the SQL tools if not present
@@ -92,7 +92,7 @@ echo "Example connection details:"
9292
cat << EXAMPLE_CONNECTION
9393
{
9494
"host" : "localhost",
95-
"port" : 1433,
95+
"port" : 1111,
9696
"username" : "SA",
9797
"password" : "MyS3cretPassw0rd",
9898
"database" : "sample_db"

triage/postgres-triage.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ if [ "$(docker ps -a --filter 'name=^/postgres-devdb-triage$' --format '{{.Names
99
docker start postgres-devdb-triage
1010
else
1111
echo "Container does not exist. Creating a new postgres-devdb-triage container..."
12-
docker run --name postgres-devdb-triage -e POSTGRES_PASSWORD=mysecretpassword -p 5432:5432 -d postgres
12+
docker run --name postgres-devdb-triage -e POSTGRES_PASSWORD=mysecretpassword -p 3333:5432 -d postgres
1313
fi
1414

1515
# Wait for the database to start
@@ -51,7 +51,7 @@ echo "Example connection details:"
5151
cat << EXAMPLE_CONNECTION
5252
{
5353
"host" : "localhost",
54-
"port" : 5432,
54+
"port" : 3333,
5555
"username" : "postgres",
5656
"password" : "mysecretpassword",
5757
"database" : "sample_db"

0 commit comments

Comments
 (0)