Skip to content

Commit e7d9551

Browse files
committed
Improve cell actions UX
1 parent dac7b4f commit e7d9551

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

src/database-engines/mssql-engine.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export class MssqlEngine implements DatabaseEngine {
8282
isPrimaryKey: column.Key === 1,
8383
isNumeric: this.getNumericColumnTypeNamesLowercase().includes(column.Type.toLowerCase()),
8484
isPlainTextType: this.getPlainStringTypes().includes(column.Type.toLowerCase()),
85-
isEditable: editableColumnTypeNamesLowercase.includes(column.Type.toLowerCase()),
85+
isEditable: editableColumnTypeNamesLowercase.includes(column.Type.toLowerCase()) || editableColumnTypeNamesLowercase.some(edtiableColumn => column.Type.toLowerCase().startsWith(edtiableColumn)),
8686
isNullable: column.Null === 'YES',
8787
foreignKey
8888
})

src/database-engines/postgres-engine.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export class PostgresEngine implements DatabaseEngine {
9797
isNumeric: this.getNumericColumnTypeNamesLowercase().includes(column.type.toLowerCase()),
9898
isPlainTextType: this.getPlainStringTypes().includes(column.type.toLowerCase()),
9999
isNullable: false, // <- TODO: implement and update https://github.com/damms005/devdb-vscode/blob/5f0ead1b0e466c613af7d9d39a9d4ef4470e9ebf/README.md#L127
100-
isEditable: editableColumnTypeNamesLowercase.includes(column.type.toLowerCase()),
100+
isEditable: editableColumnTypeNamesLowercase.includes(column.type.toLowerCase()) || editableColumnTypeNamesLowercase.some(edtiableColumn => column.type.toLowerCase().startsWith(edtiableColumn)),
101101
foreignKey
102102
},
103103
// add a temporary property for sorting via type assertion

src/types.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export interface Column {
1414
isNumeric?: boolean,
1515
isPlainTextType: boolean,
1616
isNullable: boolean,
17-
isEditable?: boolean,
17+
isEditable: boolean,
1818
foreignKey?: ForeignKey
1919
}
2020

0 commit comments

Comments
 (0)