Skip to content

Commit 0fe557b

Browse files
authored
Merge pull request #52 from nat-n/fix_type_imports
Only import types from grpclib when type checking
2 parents 1a87ea4 + 91f586f commit 0fe557b

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

betterproto/__init__.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,16 @@
2727
TYPE_CHECKING,
2828
)
2929

30-
import grpclib.client
30+
3131
import grpclib.const
3232
import stringcase
3333

3434
from .casing import safe_snake_case
3535

3636
if TYPE_CHECKING:
3737
from grpclib._protocols import IProtoMessage
38+
from grpclib.client import Channel
39+
from grpclib.metadata import Deadline
3840

3941
if not (sys.version_info.major == 3 and sys.version_info.minor >= 7):
4042
# Apply backport of datetime.fromisoformat from 3.7
@@ -1073,10 +1075,10 @@ class ServiceStub(ABC):
10731075

10741076
def __init__(
10751077
self,
1076-
channel: grpclib.client.Channel,
1078+
channel: "Channel",
10771079
*,
10781080
timeout: Optional[float] = None,
1079-
deadline: Optional[grpclib.metadata.Deadline] = None,
1081+
deadline: Optional["Deadline"] = None,
10801082
metadata: Optional[_MetadataLike] = None,
10811083
) -> None:
10821084
self.channel = channel
@@ -1087,7 +1089,7 @@ def __init__(
10871089
def __resolve_request_kwargs(
10881090
self,
10891091
timeout: Optional[float],
1090-
deadline: Optional[grpclib.metadata.Deadline],
1092+
deadline: Optional["Deadline"],
10911093
metadata: Optional[_MetadataLike],
10921094
):
10931095
return {
@@ -1103,7 +1105,7 @@ async def _unary_unary(
11031105
response_type: Type[T],
11041106
*,
11051107
timeout: Optional[float] = None,
1106-
deadline: Optional[grpclib.metadata.Deadline] = None,
1108+
deadline: Optional["Deadline"] = None,
11071109
metadata: Optional[_MetadataLike] = None,
11081110
) -> T:
11091111
"""Make a unary request and return the response."""
@@ -1126,7 +1128,7 @@ async def _unary_stream(
11261128
response_type: Type[T],
11271129
*,
11281130
timeout: Optional[float] = None,
1129-
deadline: Optional[grpclib.metadata.Deadline] = None,
1131+
deadline: Optional["Deadline"] = None,
11301132
metadata: Optional[_MetadataLike] = None,
11311133
) -> AsyncGenerator[T, None]:
11321134
"""Make a unary request and return the stream response iterator."""

0 commit comments

Comments
 (0)