Skip to content

Commit 75a4c23

Browse files
committed
Add optional deps to dev-deps
So contributors dont have to remember to run poetry install with `-E compiler`
1 parent 8edec81 commit 75a4c23

File tree

4 files changed

+243
-69
lines changed

4 files changed

+243
-69
lines changed

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
python-version: 3.7
1717
- uses: Gr1N/setup-poetry@v2
1818
- name: Install dependencies
19-
run: make setup
19+
run: poetry install
2020
- name: Run black
2121
run: make check-style
2222

@@ -34,7 +34,7 @@ jobs:
3434
- name: Install dependencies
3535
run: |
3636
sudo apt install protobuf-compiler libprotobuf-dev
37-
make setup
37+
poetry install
3838
- name: Run tests
3939
run: make full-test
4040

Makefile

+1-4
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@ help: ## - Show this help.
33

44
# Dev workflow tasks
55

6-
setup: ## - Setup the virtualenv with poetry
7-
poetry install -E compiler
8-
9-
generate: ## - Generate test cases (do this once before running test)
6+
generate: ## - Generate test cases (do this once before running test)
107
poetry run ./betterproto/tests/generate.py
118

129
test: ## - Run tests

0 commit comments

Comments
 (0)