Fix most mypy warnings

Author: nat-n

betterproto/__init__.py

@@ -440,7 +440,7 @@ class ProtoClassMetadata:
 
     def __init__(self, cls: Type["Message"]):
         by_field = {}
-        by_group = {}
+        by_group: Dict[str, Set] = {}
         by_field_name = {}
         by_field_number = {}
 
@@ -780,7 +780,7 @@ def FromString(cls: Type[T], data: bytes) -> T:
 
     def to_dict(
         self, casing: Casing = Casing.CAMEL, include_default_values: bool = False
-    ) -> dict:
+    ) -> Dict[str, Any]:
         """
         Returns a dict representation of this message instance which can be
         used to serialize to e.g. JSON. Defaults to camel casing for

betterproto/_types.py

@@ -1,4 +1,8 @@
-from typing import TypeVar
+from typing import TYPE_CHECKING, TypeVar
+
+if TYPE_CHECKING:
+    from . import Message
+    from grpclib._protocols import IProtoMessage
 
 # Bound type variable to allow methods to return `self` of subclasses
 T = TypeVar("T", bound="Message")

betterproto/grpc/grpclib_client.py

@@ -3,9 +3,10 @@
 import grpclib.const
 from typing import (
     Any,
+    AsyncIterable,
     AsyncIterator,
     Collection,
-    Iterator,
+    Iterable,
     Mapping,
     Optional,
     Tuple,
@@ -23,7 +24,7 @@
 
 _Value = Union[str, bytes]
 _MetadataLike = Union[Mapping[str, _Value], Collection[Tuple[str, _Value]]]
-_MessageSource = Union[Iterator["IProtoMessage"], AsyncIterator["IProtoMessage"]]
+_MessageSource = Union[Iterable["IProtoMessage"], AsyncIterable["IProtoMessage"]]
 
 
 class ServiceStub(ABC):
@@ -158,7 +159,7 @@ async def _stream_stream(
 
     @staticmethod
     async def _send_messages(stream, messages: _MessageSource):
-        if hasattr(messages, "__aiter__"):
+        if isinstance(messages, AsyncIterable):
             async for message in messages:
                 await stream.send_message(message)
         else:

betterproto/grpc/util/async_channel.py

@@ -53,7 +53,7 @@ async def send_from(
         """
         if self._closed:
             raise self.Error("Cannot send through a closed channel")
-        if hasattr(source, "__aiter__"):
+        if isinstance(source, AsyncIterable):
             async for item in source:
                 await self._queue.put(item)
         else:

betterproto/plugin.py

@@ -6,7 +6,7 @@
 import stringcase
 import sys
 import textwrap
-from typing import Dict, List, Optional, Type
+from typing import Dict, List, Optional, Type, Union
 from betterproto.casing import safe_snake_case
 
 try:
@@ -120,8 +120,8 @@ def py_type(
         raise NotImplementedError(f"Unknown type {descriptor.type}")
 
 
-def get_py_zero(type_num: int) -> str:
-    zero = 0
+def get_py_zero(type_num: int) -> Union[str, float]:
+    zero: Union[str, float] = 0
     if type_num in []:
         zero = 0.0
     elif type_num == 8: