Skip to content

Commit bd9ee1e

Browse files
author
Artur Ciocanu
committed
Ensure checkstyle can be imported into IDE
Signed-off-by: Artur Ciocanu <[email protected]>
1 parent 6e0f267 commit bd9ee1e

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

checkstyle.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@
253253
value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
254254
</module>
255255
<module name="JavadocMethod">
256-
<property name="scope" value="public"/>
256+
<property name="accessModifiers" value="public"/>
257257
<property name="allowedAnnotations" value="Override, Test"/>
258258
</module>
259259
<module name="MissingJavadocMethod">

pom.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,10 +207,9 @@
207207
<plugin>
208208
<groupId>org.apache.maven.plugins</groupId>
209209
<artifactId>maven-checkstyle-plugin</artifactId>
210-
<version>3.3.1</version>
210+
<version>3.4.0</version>
211211
<configuration>
212212
<configLocation>checkstyle.xml</configLocation>
213-
<encoding>UTF-8</encoding>
214213
<consoleOutput>true</consoleOutput>
215214
<violationSeverity>warning</violationSeverity>
216215
<failOnViolation>true</failOnViolation>
@@ -233,7 +232,7 @@
233232
<dependency>
234233
<groupId>com.puppycrawl.tools</groupId>
235234
<artifactId>checkstyle</artifactId>
236-
<version>8.37</version>
235+
<version>10.17.0</version>
237236
</dependency>
238237
</dependencies>
239238
</plugin>

sdk-workflows/src/main/java/io/dapr/workflows/client/WorkflowInstanceStatus.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,7 @@ public boolean isRunning() {
149149
* {@link WorkflowRuntimeStatus#FAILED}, or
150150
* {@link WorkflowRuntimeStatus#TERMINATED}.
151151
*
152-
* @return {@code true} if the workflow was in a terminal state; otherwise
153-
* {@code false}
152+
* @return {@code true} if the workflow was in a terminal state; otherwise {@code false}
154153
*/
155154
public boolean isCompleted() {
156155
return orchestrationMetadata.isCompleted();

0 commit comments

Comments
 (0)