Skip to content

Commit 665d9d3

Browse files
committed
Merge pull request honza#282 from chrisyue/master
[php] [symfony] some bugfix and improve
2 parents 0f61100 + fe4c59f commit 665d9d3

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

Diff for: UltiSnips/php.snippets

+7-6
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,15 @@ ${1:public} function __construct($2)
6262
endsnippet
6363

6464
snippet sg "Setter and Getter" b
65-
6665
/**
67-
* @var ${3:`!p snip.rv = t[2].capitalize()`}
66+
* @var ${3:`!p snip.rv = t[2][0:1].upper() + t[2][1:]`}
67+
*
68+
* ${4}
6869
*/
69-
${1:protected} $$2;
70+
${1:protected} $${2};
7071

71-
public function set`!p snip.rv = t[2].capitalize()`(`!p
72-
if re.match(r'[A-Z].*', t[3]):
72+
public function set`!p snip.rv = t[2][0:1].upper() + t[2][1:]`(`!p
73+
if re.match(r'^(\\|[A-Z]).*', t[3]):
7374
snip.rv = t[3] + ' '
7475
else:
7576
snip.rv = ''
@@ -80,7 +81,7 @@ else:
8081
return $this;
8182
}
8283

83-
public function get`!p snip.rv = t[2].capitalize()`()
84+
public function get`!p snip.rv = t[2][0:1].upper() + t[2][1:]`()
8485
{
8586
return $this->$2;
8687
}

Diff for: UltiSnips/php/symfony2.snippets

+6-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ snippet act "symfony2 action" b
3333
public function ${1}Action(${2})
3434
{
3535
${6}
36-
return $this->redirect($this->generate('home', [], false));
36+
return $this->redirect($this->generateUrl('home', [], false));
3737
}
3838
endsnippet
3939

@@ -175,7 +175,11 @@ tmp = re.sub(r'\B([A-Z])', r'_\1', tmp)
175175
snip.rv = tmp.lower()
176176
`")
177177
*/
178-
class `!p
178+
`!p
179+
m = re.search(r'Abstract', path)
180+
if m:
181+
snip.rv = 'abstract '
182+
`class `!p
179183
snip.rv = re.match(r'.*(?=\.)', fn).group()
180184
`
181185
{

0 commit comments

Comments
 (0)