Skip to content
This repository was archived by the owner on Apr 6, 2021. It is now read-only.

Commit c24382e

Browse files
authored
Refactor tests to async/await (#72)
Remove a bunch of `expectAsync` since the work is all tracked in the `Future` the test runner will already fail if something doesn't complete. In virtual_host test extract common server handling to a `setUp` and `tearDown`. Remove the test 'multiple-host' since it is identical to 'wildcard-sub-domain' test. Tweak travis config to only run the analyzer with the dev SDK to work around false errors on older SDKs. Rename some test utilities from `test` to `check` to avoid conflicts with the `test` function from `package:test`.
1 parent 721f5f8 commit c24382e

6 files changed

+580
-725
lines changed

.travis.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@ dart:
66

77
dart_task:
88
- test
9-
- dartanalyzer: --fatal-infos --fatal-warnings .
109

1110
matrix:
1211
include:
13-
- dart: dev
14-
dart_task: dartfmt
12+
- dart: dev
13+
dart_task: dartfmt
14+
- dart: dev
15+
dart_task:
16+
dartanalyzer: --fatal-infos --fatal-warnings .
1517

1618
# Only building master means that we don't run two builds for each pull request.
1719
branches:

0 commit comments

Comments
 (0)