Skip to content

Commit 592694e

Browse files
authored
Remove redundant ModelElement.filePath implementations (#3751)
1 parent 46947ba commit 592694e

File tree

4 files changed

+2
-52
lines changed

4 files changed

+2
-52
lines changed

lib/src/generator/templates.runtime_renderers.dart

-44
Original file line numberDiff line numberDiff line change
@@ -4752,28 +4752,6 @@ class _Renderer_Extension extends RendererBase<Extension> {
47524752
parent: r);
47534753
},
47544754
),
4755-
'filePath': Property(
4756-
getValue: (CT_ c) => c.filePath,
4757-
renderVariable:
4758-
(CT_ c, Property<CT_> self, List<String> remainingNames) {
4759-
if (remainingNames.isEmpty) {
4760-
return self.getValue(c).toString();
4761-
}
4762-
var name = remainingNames.first;
4763-
var nextProperty =
4764-
_Renderer_String.propertyMap().getValue(name);
4765-
return nextProperty.renderVariable(
4766-
self.getValue(c) as String,
4767-
nextProperty,
4768-
[...remainingNames.skip(1)]);
4769-
},
4770-
isNullValue: (CT_ c) => false,
4771-
renderValue: (CT_ c, RendererBase<CT_> r,
4772-
List<MustachioNode> ast, StringSink sink) {
4773-
_render_String(c.filePath, ast, r.template, sink,
4774-
parent: r);
4775-
},
4776-
),
47774755
'kind': Property(
47784756
getValue: (CT_ c) => c.kind,
47794757
renderVariable: (CT_ c, Property<CT_> self,
@@ -5200,28 +5178,6 @@ class _Renderer_ExtensionType extends RendererBase<ExtensionType> {
52005178
parent: r);
52015179
},
52025180
),
5203-
'filePath': Property(
5204-
getValue: (CT_ c) => c.filePath,
5205-
renderVariable:
5206-
(CT_ c, Property<CT_> self, List<String> remainingNames) {
5207-
if (remainingNames.isEmpty) {
5208-
return self.getValue(c).toString();
5209-
}
5210-
var name = remainingNames.first;
5211-
var nextProperty =
5212-
_Renderer_String.propertyMap().getValue(name);
5213-
return nextProperty.renderVariable(
5214-
self.getValue(c) as String,
5215-
nextProperty,
5216-
[...remainingNames.skip(1)]);
5217-
},
5218-
isNullValue: (CT_ c) => false,
5219-
renderValue: (CT_ c, RendererBase<CT_> r,
5220-
List<MustachioNode> ast, StringSink sink) {
5221-
_render_String(c.filePath, ast, r.template, sink,
5222-
parent: r);
5223-
},
5224-
),
52255181
'inheritanceChain': Property(
52265182
getValue: (CT_ c) => c.inheritanceChain,
52275183
renderVariable: (CT_ c, Property<CT_> self,

lib/src/model/extension.dart

-3
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,6 @@ class Extension extends Container {
9292
...typeParameters,
9393
];
9494

95-
@override
96-
String get filePath => '${library.dirName}/$fileName';
97-
9895
@override
9996
String get sidebarPath => '${library.dirName}/$name-extension-sidebar.html';
10097

lib/src/model/extension_type.dart

-3
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,6 @@ class ExtensionType extends InheritingContainer with Constructable {
6565
...interfaceElements.expandInheritanceChain,
6666
];
6767

68-
@override
69-
String get filePath => '${library.dirName}/$fileName';
70-
7168
@override
7269
String get fileName => '$name-extension-type.html';
7370

lib/src/model/library.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -184,12 +184,12 @@ class Library extends ModelElement
184184
ModelElement? get enclosingElement => null;
185185

186186
@override
187-
String get filePath => '${library.dirName}/$fileName';
187+
String get filePath => '$dirName/$fileName';
188188

189189
@override
190190
String get fileName => '$dirName-library.html';
191191

192-
String get sidebarPath => '${library.dirName}/$dirName-library-sidebar.html';
192+
String get sidebarPath => '$dirName/$dirName-library-sidebar.html';
193193

194194
/// The library template manually includes 'packages' in the left/above
195195
/// sidebar.

0 commit comments

Comments
 (0)