From 87dc01652d7f9b886e3df0e859bdb67392f36b55 Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Thu, 9 Nov 2023 10:37:18 -0800 Subject: [PATCH] Remove unused parameter in zone thing --- lib/src/dartdoc.dart | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/src/dartdoc.dart b/lib/src/dartdoc.dart index c6f5d22b15..c9a98e9eae 100644 --- a/lib/src/dartdoc.dart +++ b/lib/src/dartdoc.dart @@ -260,9 +260,7 @@ class Dartdoc { /// /// Passing in a [postProcessCallback] to do additional processing after /// the documentation is generated. - void executeGuarded([ - Future Function(DartdocOptionContext)? postProcessCallback, - ]) { + void executeGuarded() { onCheckProgress.listen(logProgress); // This function should *never* `await runZonedGuarded` because the errors // thrown in [generateDocs] are uncaught. We want this because uncaught @@ -270,14 +268,12 @@ class Dartdoc { // // If you await the zone, the code that comes after the await is not // executed if the zone dies due to an uncaught error. To avoid this, - // confusion, never `await runZonedGuarded` and never change the return - // value of [executeGuarded]. + // confusion, never `await runZonedGuarded`. runZonedGuarded( () async { runtimeStats.startPerfTask('generateDocs'); await generateDocs(); runtimeStats.endPerfTask(); - await postProcessCallback?.call(config); }, (e, stackTrace) { stderr.writeln('\n$_dartdocFailedMessage: $e\n$stackTrace');