Skip to content

Commit 3a3fac5

Browse files
MichaelRFairhurstjakobr-google
authored andcommitted
Add void declarations to methods with implicit dynamic returning void values, which may be illegal in dart 2, but in either case, expresses the current intent better.
1 parent ae5c184 commit 3a3fac5

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

pkgs/http2/test/client_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ main() {
526526
});
527527
}
528528

529-
clientTest(
529+
void clientTest(
530530
String name,
531531
Future<Null> func(
532532
ClientTransportConnection clientConnection,

pkgs/http2/test/server_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ main() {
194194
});
195195
}
196196

197-
serverTest(
197+
void serverTest(
198198
String name,
199199
func(ServerTransportConnection serverConnection, FrameWriter frameWriter,
200200
StreamIterator<Frame> frameReader, Future<Frame> readNext())) {

pkgs/http2/test/src/streams/helper.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ expectEmptyStream(Stream s) {
2424
s.listen(expectAsync1((_) {}, count: 0), onDone: expectAsync0(() {}));
2525
}
2626

27-
streamTest(String name,
27+
void streamTest(String name,
2828
func(ClientTransportConnection client, ServerTransportConnection server),
2929
{ClientSettings settings}) {
3030
return test(name, () {
@@ -36,7 +36,7 @@ streamTest(String name,
3636
});
3737
}
3838

39-
framesTest(String name, func(frameWriter, frameStream)) {
39+
void framesTest(String name, func(frameWriter, frameStream)) {
4040
return test(name, () {
4141
var c = new StreamController<List<int>>();
4242
var fw = new FrameWriter(null, c, new ActiveSettings());

pkgs/http2/test/transport_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ main() {
469469
});
470470
}
471471

472-
transportTest(String name,
472+
void transportTest(String name,
473473
func(ClientTransportConnection client, ServerTransportConnection server),
474474
{ClientSettings clientSettings, ServerSettings serverSettings}) {
475475
return test(name, () {

0 commit comments

Comments
 (0)