Skip to content

Commit f28092d

Browse files
authored
Update lints, require Dart 3.2 (dart-archive/http_multi_server#63)
1 parent 5a87d97 commit f28092d

File tree

5 files changed

+10
-16
lines changed

5 files changed

+10
-16
lines changed

pkgs/http_multi_server/.github/workflows/test-package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
matrix:
4848
# Add macos-latest and/or windows-latest if relevant for this package.
4949
os: [ubuntu-latest]
50-
sdk: [2.19.0, dev]
50+
sdk: [3.2, dev]
5151
steps:
5252
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
5353
- uses: dart-lang/setup-dart@ca7e6fee45ffbd82b555a7ebfc236d2c86439f5b

pkgs/http_multi_server/CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
## 3.2.2-dev
1+
## 3.2.2-wip
22

3-
* Require Dart 2.19
3+
* Require Dart 3.2
44

55
## 3.2.1
66

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# https://dart.dev/tools/analysis#the-analysis-options-file
12
include: package:dart_flutter_team_lints/analysis_options.yaml
23

34
analyzer:
@@ -10,23 +11,16 @@ linter:
1011
- avoid_classes_with_only_static_members
1112
- avoid_private_typedef_functions
1213
- avoid_redundant_argument_values
13-
- avoid_returning_null
14-
- avoid_returning_null_for_future
1514
- avoid_returning_this
1615
- avoid_unused_constructor_parameters
1716
- cancel_subscriptions
1817
- cascade_invocations
19-
- comment_references
2018
- join_return_with_assignment
2119
- literal_only_boolean_expressions
2220
- no_adjacent_strings_in_list
2321
- no_runtimeType_toString
2422
- package_api_docs
25-
- prefer_const_constructors
2623
- prefer_const_declarations
2724
- prefer_expression_function_bodies
2825
- prefer_final_locals
29-
- prefer_relative_imports
30-
- test_types_in_equals
3126
- use_string_buffers
32-
- use_super_parameters

pkgs/http_multi_server/pubspec.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
name: http_multi_server
2-
version: 3.2.2-dev
2+
version: 3.2.2-wip
33
description: >-
44
A dart:io HttpServer wrapper that handles requests from multiple servers.
55
repository: https://github.com/dart-lang/http_multi_server
66

77
environment:
8-
sdk: '>=2.19.0 <3.0.0'
8+
sdk: ^3.2.0
99

1010
dependencies:
1111
async: ^2.5.0
1212

1313
dev_dependencies:
14-
dart_flutter_team_lints: ^1.0.0
15-
http: ^0.13.0
14+
dart_flutter_team_lints: ^2.0.0
15+
http: ^1.0.0
1616
shelf: ^1.4.0
1717
test: ^1.16.0

pkgs/http_multi_server/test/http_multi_server_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,8 @@ void main() {
128128

129129
test('connectionsInfo sums the values for all servers', () {
130130
var pendingRequests = 0;
131-
final awaitingResponseCompleter = Completer();
132-
final sendResponseCompleter = Completer();
131+
final awaitingResponseCompleter = Completer<void>();
132+
final sendResponseCompleter = Completer<void>();
133133
multiServer.listen((request) {
134134
sendResponseCompleter.future.then((_) {
135135
request.response.write('got request');

0 commit comments

Comments
 (0)