Skip to content

Feature request: support SOCKS proxies #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isoos opened this issue Mar 10, 2017 · 6 comments
Closed

Feature request: support SOCKS proxies #65

isoos opened this issue Mar 10, 2017 · 6 comments

Comments

@isoos
Copy link

isoos commented Mar 10, 2017

No description provided.

@nex3
Copy link
Member

nex3 commented Mar 10, 2017

The http package is designed to be composable and to make it easy to make middleware that add special functionality or implement a new way of sending requests. This is a great example of something that would work well as middleware.

@nex3 nex3 closed this as completed Mar 10, 2017
@isoos
Copy link
Author

isoos commented Mar 10, 2017

It is not immediately clear for me how this could be achieved as a middleware. Could you please leave pointers here, so that later it can be picked up by somebody?

@nex3
Copy link
Member

nex3 commented Mar 10, 2017

Maybe a custom client would work better than middleware? I don't know a lot about the SOCKS protocol. But however you were envisioning it being implemented in this package, you could implement elsewhere.

@isoos
Copy link
Author

isoos commented Mar 10, 2017

I was thinking more of curl, which has a --socks5 command line flag. For example node.js has this http client library that was specifically built for socks support: https://github.com/mattcg/socks5-http-client

I am not that familiar with the socks protocol either, but given the examples, it feels it belongs to the http client. Btw. this is one of last remnants on my server which is using external process (curl) instead of dart-only libraries.

@nex3
Copy link
Member

nex3 commented Mar 10, 2017

This library isn't intended to include support for every protocol; it's intended to be a solid foundation on which that support can be added externally.

@wuujiann
Copy link

wuujiann commented Sep 9, 2019

Can you give me a pointer on how to add SOCKS proxy support externally to this http package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants