Automated g4 rollback of changelist 264686901.

*** Reason for rollback ***

Google Fiber application doesn't build: https://test.corp.google.com/ui#cl=264686901

*** Original change description ***

Make Intl generated code pass most current lint options
Mostly using ignore_for_file, but fixing a few of the most obvious issues
Started out as integrating dart-archive/intl_translation#31 but then expanded.

***

PiperOrigin-RevId: 264727285

Author: Dart Team

pkgs/intl_translation/CHANGELOG.md

@@ -1,7 +1,5 @@
 ## 0.17.6
   * Strip indentation from generated JSON output to improve codesize.
-  * Make generated code not trigger most lints, either by fixing issues
-    or by using lots of ignore_for_file directives.
 
 ## 0.17.5
   * Allow multiple ARB files with the same locale and combine

pkgs/intl_translation/lib/generate_localized.dart

@@ -57,7 +57,7 @@ class MessageGeneration {
   /// so it's left undefined.
   String package;
 
-  bool get releaseMode => codegenMode == 'release';
+  get releaseMode => codegenMode == 'release';
 
   bool get jsonMode => false;
 
@@ -105,8 +105,10 @@ class MessageGeneration {
     for (var translation in usableTranslations) {
       // Some messages we generate as methods in this class. Simpler ones
       // we inline in the map from names to messages.
-      var messagesThatNeedMethods =
-          translation.originalMessages.where(_hasArguments).toSet().toList();
+      var messagesThatNeedMethods = translation.originalMessages
+          .where((each) => _hasArguments(each))
+          .toSet()
+          .toList();
       for (var original in messagesThatNeedMethods) {
         output
           ..write("  ")
@@ -151,21 +153,22 @@ class MessageGeneration {
 // messages from the main program should be duplicated here with the same
 // function name.
 
-// Ignore issues from commonly used lints in this file.
-// ignore_for_file:unnecessary_brace_in_string_interps
-// ignore_for_file:prefer_single_quotes,comment_references, directives_ordering
-// ignore_for_file:annotate_overrides,prefer_generic_function_type_aliases
-// ignore_for_file:unused_import, file_names
+// ignore_for_file: unnecessary_brace_in_string_interps
 
 import 'package:$intlImportPath/intl.dart';
 import 'package:$intlImportPath/message_lookup_by_library.dart';
 $extraImports
-final messages = MessageLookup();
+// ignore: unnecessary_new
+final messages = new MessageLookup();
 
-typedef String MessageIfAbsent(String messageStr, List<dynamic> args);
+// ignore: unused_element
+final _keepAnalysisHappy = Intl.defaultLocale;
+
+// ignore: non_constant_identifier_names
+typedef MessageIfAbsent(String message_str, List<dynamic> args);
 
 class MessageLookup extends MessageLookupByLibrary {
-  String get localeName => '$locale';
+  get localeName => '$locale';
 
 """ +
       (releaseMode ? overrideLookup : "");
@@ -182,7 +185,8 @@ class MessageLookup extends MessageLookupByLibrary {
       // If there's no message_str, then we are an internal lookup, e.g. an
       // embedded plural, and shouldn't fail.
       if (message_str == null) return null;
-      throw UnsupportedError(
+      // ignore: unnecessary_new
+      throw new UnsupportedError(
           "No translation found for message '\$name',\\n"
           "  original text '\$message_str'");
     }
@@ -211,11 +215,12 @@ class MessageLookup extends MessageLookupByLibrary {
       var locale = Intl.canonicalizedLocale(rawLocale);
       var loadOperation = (useDeferredLoading)
           ? "  '$locale': ${libraryName(locale)}.loadLibrary,\n"
-          : "  '$locale': () => Future.value(null),\n";
+          : "// ignore: unnecessary_new\n"
+              "  '$locale': () => new Future.value(null),\n";
       output.write(loadOperation);
     }
     output.write("};\n");
-    output.write("\nMessageLookupByLibrary _findExact(String localeName) {\n"
+    output.write("\nMessageLookupByLibrary _findExact(localeName) {\n"
         "  switch (localeName) {\n");
     for (var rawLocale in allLocales) {
       var locale = Intl.canonicalizedLocale(rawLocale);
@@ -233,17 +238,11 @@ class MessageLookup extends MessageLookupByLibrary {
 // This is a library that looks up messages for specific locales by
 // delegating to the appropriate library.
 
-// Ignore issues from commonly used lints in this file.
-// ignore_for_file:implementation_imports, file_names
-// ignore_for_file:unnecessary_brace_in_string_interps, directives_ordering
-// ignore_for_file:argument_type_not_assignable, invalid_assignment
-// ignore_for_file:prefer_single_quotes, prefer_generic_function_type_aliases
-// ignore_for_file:comment_references
-
 import 'dart:async';
 
 import 'package:$intlImportPath/intl.dart';
 import 'package:$intlImportPath/message_lookup_by_library.dart';
+// ignore: implementation_imports
 import 'package:$intlImportPath/src/intl_helpers.dart';
 
 """;
@@ -261,13 +260,17 @@ Future<bool> initializeMessages(String localeName) async {
     (locale) => _deferredLibraries[locale] != null,
     onFailure: (_) => null);
   if (availableLocale == null) {
-    return Future.value(false);
+    // ignore: unnecessary_new
+    return new Future.value(false);
   }
   var lib = _deferredLibraries[availableLocale];
-  await (lib == null ? Future.value(false) : lib());
-  initializeInternalMessageLookup(() => CompositeMessageLookup());
+  // ignore: unnecessary_new
+  await (lib == null ? new Future.value(false) : lib());
+  // ignore: unnecessary_new
+  initializeInternalMessageLookup(() => new CompositeMessageLookup());
   messageLookup.addLocale(availableLocale, _findGeneratedMessagesFor);
-  return Future.value(true);
+  // ignore: unnecessary_new
+  return new Future.value(true);
 }
 
 bool _messagesExistFor(String locale) {
@@ -278,7 +281,7 @@ bool _messagesExistFor(String locale) {
   }
 }
 
-MessageLookupByLibrary _findGeneratedMessagesFor(String locale) {
+MessageLookupByLibrary _findGeneratedMessagesFor(locale) {
   var actualLocale = Intl.verifiedLocale(locale, _messagesExistFor,
       onFailure: (_) => null);
   if (actualLocale == null) return null;
@@ -325,9 +328,9 @@ import '${generatedFilePrefix}messages_all.dart' show evaluateJsonTemplate;
   void writeTranslations(
       Iterable<TranslatedMessage> usableTranslations, String locale) {
     output.write(r"""
-  Map<String, dynamic> _messages;
-  Map<String,dynamic> get messages => _messages ??=
-      const JsonDecoder().convert(messageText) as Map<String, dynamic>;
+  var _messages;
+  // ignore: unnecessary_new
+  get messages => _messages ??= new JsonDecoder().convert(messageText);
 """);
 
     output.write("  static final messageText = ");
@@ -355,7 +358,7 @@ import '${generatedFilePrefix}messages_all.dart' show evaluateJsonTemplate;
 ///   * \['Intl.gender', String gender, (templates for female, male, other)\]
 ///   * \['Intl.select', String choice, { 'case' : template, ...} \]
 ///   * \['text alternating with ', 0 , ' indexes in the argument list'\]
-String evaluateJsonTemplate(dynamic input, List<dynamic> args) {
+String evaluateJsonTemplate(Object input, List<dynamic> args) {
   if (input == null) return null;
   if (input is String) return input;
   if (input is int) {
@@ -395,7 +398,8 @@ String evaluateJsonTemplate(dynamic input, List<dynamic> args) {
 
    // If we get this far, then we are a basic interpolation, just strings and
    // ints.
-   var output = StringBuffer();
+   // ignore: unnecessary_new
+   var output = new StringBuffer();
    for (var entry in template) {
      if (entry is int) {
        output.write("\${args[entry]}");