Skip to content

Commit 5622032

Browse files
committed
Address review comments.
1 parent 73113e4 commit 5622032

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

working/macros/feature-specification.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,9 @@ whatever the application order. In most cases this achieved by the split into
273273
phases: within each phase macros can run in any order because the output is not
274274
visible to other macros until the next phase. As a special case, introspection
275275
of types in Phase 2 waits as needed for other macro applications to complete,
276-
failing if there are cycles.
276+
failing if there is a cycle.
277+
278+
TODO: give an example of a cycle.
277279
278280
### Augmentation library structure and ordering
279281
@@ -590,10 +592,7 @@ returning, meaning it waits for the macro applications on the target type to
590592
finish.
591593

592594
If a cycle arises in macro applications waiting for other macro applications to
593-
complete then a special value is returned indicating that introspection is not
594-
possible due to a cycle. If the macro can still correctly apply then it should
595-
continue normally. If it cannot succeed without the introspection results then
596-
it should report an error.
595+
complete then a `StateError ` is thrown.
597596

598597
Rules might be added in future to decide in some specific cases which macro
599598
should run with incomplete introspection results to break a cycle. For example,

0 commit comments

Comments
 (0)