Skip to content

Commit 1097a9f

Browse files
authored
[jnigen] Summarizer fix (#116)
1 parent 269c96c commit 1097a9f

File tree

16 files changed

+1127
-4441
lines changed

16 files changed

+1127
-4441
lines changed

pkgs/jnigen/example/in_app_java/android/app/src/main/java/com/example/in_app_java/AndroidUtils.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,11 @@
99
import androidx.annotation.Keep;
1010

1111
@Keep
12-
public class AndroidUtils {
13-
static void showToast(Activity mainActivity, CharSequence text, int duration) {
12+
public abstract class AndroidUtils {
13+
// Hide constructor
14+
private AndroidUtils() {}
15+
16+
public static void showToast(Activity mainActivity, CharSequence text, int duration) {
1417
mainActivity.runOnUiThread(() -> Toast.makeText(mainActivity, text, duration).show());
1518
}
1619
}

pkgs/jnigen/example/in_app_java/lib/android_utils.dart

+1-8
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,6 @@ final ffi.Pointer<T> Function<T extends ffi.NativeType>(String sym) jniLookup =
2222
class AndroidUtils extends jni.JniObject {
2323
AndroidUtils.fromRef(ffi.Pointer<ffi.Void> ref) : super.fromRef(ref);
2424

25-
static final _ctor = jniLookup<ffi.NativeFunction<jni.JniResult Function()>>(
26-
"AndroidUtils__ctor")
27-
.asFunction<jni.JniResult Function()>();
28-
29-
/// from: public void <init>()
30-
AndroidUtils() : super.fromRef(_ctor().object);
31-
3225
static final _showToast = jniLookup<
3326
ffi.NativeFunction<
3427
jni.JniResult Function(ffi.Pointer<ffi.Void>,
@@ -37,7 +30,7 @@ class AndroidUtils extends jni.JniObject {
3730
jni.JniResult Function(
3831
ffi.Pointer<ffi.Void>, ffi.Pointer<ffi.Void>, int)>();
3932

40-
/// from: static void showToast(android.app.Activity mainActivity, java.lang.CharSequence text, int duration)
33+
/// from: static public void showToast(android.app.Activity mainActivity, java.lang.CharSequence text, int duration)
4134
static void showToast(
4235
jni.JniObject mainActivity, jni.JniObject text, int duration) =>
4336
_showToast(mainActivity.reference, text.reference, duration).check();

pkgs/jnigen/example/in_app_java/src/android_utils/android_utils.c

-16
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,6 @@ void setJniGetters(JniContext (*cg)(void), JNIEnv* (*eg)(void)) {
1818
// com.example.in_app_java.AndroidUtils
1919
jclass _c_AndroidUtils = NULL;
2020

21-
jmethodID _m_AndroidUtils__ctor = NULL;
22-
FFI_PLUGIN_EXPORT
23-
JniResult AndroidUtils__ctor() {
24-
load_env();
25-
load_class_gr(&_c_AndroidUtils, "com/example/in_app_java/AndroidUtils");
26-
if (_c_AndroidUtils == NULL)
27-
return (JniResult){.result = {.j = 0}, .exception = check_exception()};
28-
load_method(_c_AndroidUtils, &_m_AndroidUtils__ctor, "<init>", "()V");
29-
if (_m_AndroidUtils__ctor == NULL)
30-
return (JniResult){.result = {.j = 0}, .exception = check_exception()};
31-
jobject _result =
32-
(*jniEnv)->NewObject(jniEnv, _c_AndroidUtils, _m_AndroidUtils__ctor);
33-
return (JniResult){.result = {.l = to_global_ref(_result)},
34-
.exception = check_exception()};
35-
}
36-
3721
jmethodID _m_AndroidUtils__showToast = NULL;
3822
FFI_PLUGIN_EXPORT
3923
JniResult AndroidUtils__showToast(jobject mainActivity,

pkgs/jnigen/example/pdfbox_plugin/dart_example/bin/pdf_info.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import 'package:pdfbox_plugin/pdfbox_plugin.dart';
1212
void writeInfo(String file) {
1313
final inputFile = Jni.newInstance(
1414
"java/io/FileInputStream", "(Ljava/lang/String;)V", [file]);
15-
final pdDoc = PDDocument.load7(inputFile);
15+
final pdDoc = PDDocument.load6(inputFile);
1616
int pages = pdDoc.getNumberOfPages();
1717
final info = pdDoc.getDocumentInformation();
1818
final title = info.getTitle();

0 commit comments

Comments
 (0)