js_interop: replace unsupported [this] comment references with this.

Work towards dart-lang/dartdoc#3761

Sibling CL to https://dart-review.googlesource.com/c/sdk/+/365204

The analyzer has never recognized `[this]` as a valid doc comment
reference (and the `comment_references` lint rule has similarly
reported such reference attempts). dartdoc has its own algorithms
for resolving comment references, which we are dismantling in favor
of a single resolution, provided by the analyzer.

We've also decided against adding support in the analyzer (see
https://github.com/dart-lang/linter/issues/2079), so these
reference attempts should be re-written.

CoreLibraryReviewExempt: Comments only.
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I38dd476e40e4508fb6bf88c28415ff261bae5f43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366880
Reviewed-by: Srujan Gaddam <[email protected]>
Commit-Queue: Srujan Gaddam <[email protected]>
Auto-Submit: Samuel Rawlins <[email protected]>

Author: srawlins

sdk/lib/js_interop/js_interop.dart

@@ -1084,69 +1084,69 @@ extension StringToJSString on String {
 extension JSAnyOperatorExtension on JSAny? {
   // Arithmetic operators.
 
-  /// The result of <code>[this] + [any]</code> in JavaScript.
+  /// The result of <code>`this` + [any]</code> in JavaScript.
   external JSAny add(JSAny? any);
 
-  /// The result of <code>[this] - [any]</code> in JavaScript.
+  /// The result of <code>`this` - [any]</code> in JavaScript.
   external JSAny subtract(JSAny? any);
 
-  /// The result of <code>[this] * [any]</code> in JavaScript.
+  /// The result of <code>`this` * [any]</code> in JavaScript.
   external JSAny multiply(JSAny? any);
 
-  /// The result of <code>[this] / [any]</code> in JavaScript.
+  /// The result of <code>`this` / [any]</code> in JavaScript.
   external JSAny divide(JSAny? any);
 
-  /// The result of <code>[this] % [any]</code> in JavaScript.
+  /// The result of <code>`this` % [any]</code> in JavaScript.
   external JSAny modulo(JSAny? any);
 
-  /// The result of <code>[this] ** [any]</code> in JavaScript.
+  /// The result of <code>`this` ** [any]</code> in JavaScript.
   external JSAny exponentiate(JSAny? any);
 
   // Comparison operators.
 
-  /// The result of <code>[this] > [any]</code> in JavaScript.
+  /// The result of <code>`this` > [any]</code> in JavaScript.
   external JSBoolean greaterThan(JSAny? any);
 
-  /// The result of <code>[this] >= [any]</code> in JavaScript.
+  /// The result of <code>`this` >= [any]</code> in JavaScript.
   external JSBoolean greaterThanOrEqualTo(JSAny? any);
 
-  /// The result of <code>[this] < [any]</code> in JavaScript.
+  /// The result of <code>`this` < [any]</code> in JavaScript.
   external JSBoolean lessThan(JSAny? any);
 
-  /// The result of <code>[this] <= [any]</code> in JavaScript.
+  /// The result of <code>`this` <= [any]</code> in JavaScript.
   external JSBoolean lessThanOrEqualTo(JSAny? any);
 
-  /// The result of <code>[this] == [any]</code> in JavaScript.
+  /// The result of <code>`this` == [any]</code> in JavaScript.
   external JSBoolean equals(JSAny? any);
 
-  /// The result of <code>[this] != [any]</code> in JavaScript.
+  /// The result of <code>`this` != [any]</code> in JavaScript.
   external JSBoolean notEquals(JSAny? any);
 
-  /// The result of <code>[this] === [any]</code> in JavaScript.
+  /// The result of <code>`this` === [any]</code> in JavaScript.
   external JSBoolean strictEquals(JSAny? any);
 
-  /// The result of <code>[this] !== [any]</code> in JavaScript.
+  /// The result of <code>`this` !== [any]</code> in JavaScript.
   external JSBoolean strictNotEquals(JSAny? any);
 
   // Bitwise operators.
 
-  /// The result of <code>[this] >>> [any]</code> in JavaScript.
+  /// The result of <code>`this` >>> [any]</code> in JavaScript.
   // TODO(srujzs): This should return `num` or `double` instead.
   external JSNumber unsignedRightShift(JSAny? any);
 
   // Logical operators.
 
-  /// The result of <code>[this] && [any]</code> in JavaScript.
+  /// The result of <code>`this` && [any]</code> in JavaScript.
   external JSAny? and(JSAny? any);
 
-  /// The result of <code>[this] || [any]</code> in JavaScript.
+  /// The result of <code>`this` || [any]</code> in JavaScript.
   external JSAny? or(JSAny? any);
 
-  /// The result of <code>![this]</code> in JavaScript.
+  /// The result of <code>!`this`</code> in JavaScript.
   // TODO(srujzs): Change this to JSBoolean to be consistent.
   external bool get not;
 
-  /// The result of <code>!![this]</code> in JavaScript.
+  /// The result of <code>!!`this`</code> in JavaScript.
   // TODO(srujzs): Change this to JSBoolean to be consistent.
   external bool get isTruthy;
 }