Skip to content

Commit 045b9c1

Browse files
dcharkesCommit Bot
dcharkes
authored and
Commit Bot
committed
Reland "[vm/ffi] Add common C types"
We're adding these types to `dart:ffi` rather than `package:ffi` so that they can be used with `FfiNative`s. Adds `NativeType`s for the following C types: * unsigned char * signed char * short * unsigned short * int * unsigned int * long * unsigned long * long long * unsigned long long * uintptr_t * size_t * wchar_t Because the C standard only defines minimum sizes for many of these types, future platforms might diverge from the typical size even if all platforms currently agree on a size. To avoid having to reification later, we define all types as AbiSpecificIntegers rather than typedefs, even if all current target platforms agree on the size. Closes: #36140 TEST=tests/ffi/c_types_test.dart Original patch in patchset 1. * Removes `Char` for now until package:win32 has rolled to 2.3.8 in Flutter. https://pub.dev/packages/win32/versions/2.3.8/changelog https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8824468064587445729/+/u/Android_Views_Integration_Tests/stdout * Adds `c_type.dart` in `ffi_source.gni` which should fix `IntPtr` missing when analyzing `path_provider_linux`. (However, I was unable to reproduce the issue locally.) https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8824468064571399025/+/u/run_test.dart_for_flutter_plugins_shard_and_subshard_analyze/test_stdout `/tmp/flutter_plugins.KZMNMC/packages/path_provider/path_provider_linux$ ~/flt/engine/src/out/host_debug/dart-sdk/bin/dart analyze --fatal-infos` Change-Id: I89130cccba285fc9c483bb53f5710a302f2b104f Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try,dart-sdk-mac-try,dart-sdk-win-try,vm-ffi-android-debug-arm64c-try,vm-ffi-android-debug-arm-try,vm-canary-linux-debug-try,vm-fuchsia-release-x64-try,vm-kernel-gcc-linux-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-mac-debug-x64-try,vm-kernel-mac-release-arm64-try,vm-kernel-nnbd-win-release-ia32-try,vm-kernel-nnbd-win-release-x64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-win-release-x64-try,flutter-analyze-try,flutter-engine-linux-try,flutter-frontend-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229156 Reviewed-by: Martin Kustermann <[email protected]> Commit-Queue: Daco Harkes <[email protected]>
1 parent bc75541 commit 045b9c1

File tree

44 files changed

+863
-496
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+863
-496
lines changed

‎benchmarks/FfiMemory/dart/FfiMemory.dart

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -15,36 +15,6 @@ import 'dart:typed_data';
1515
import 'package:ffi/ffi.dart';
1616
import 'package:benchmark_harness/benchmark_harness.dart';
1717

18-
/// Represents a native unsigned pointer-sized integer in C.
19-
///
20-
/// [UintPtr] is not constructible in the Dart code and serves purely as marker in
21-
/// type signatures.
22-
@AbiSpecificIntegerMapping({
23-
Abi.androidArm: Uint32(),
24-
Abi.androidArm64: Uint64(),
25-
Abi.androidIA32: Uint32(),
26-
Abi.androidX64: Uint64(),
27-
Abi.fuchsiaArm64: Uint64(),
28-
Abi.fuchsiaX64: Uint64(),
29-
Abi.iosArm: Uint32(),
30-
Abi.iosArm64: Uint64(),
31-
Abi.iosX64: Uint64(),
32-
Abi.linuxArm: Uint32(),
33-
Abi.linuxArm64: Uint64(),
34-
Abi.linuxIA32: Uint32(),
35-
Abi.linuxX64: Uint64(),
36-
Abi.linuxRiscv32: Uint32(),
37-
Abi.linuxRiscv64: Uint64(),
38-
Abi.macosArm64: Uint64(),
39-
Abi.macosX64: Uint64(),
40-
Abi.windowsArm64: Uint64(),
41-
Abi.windowsIA32: Uint32(),
42-
Abi.windowsX64: Uint64(),
43-
})
44-
class UintPtr extends AbiSpecificInteger {
45-
const UintPtr();
46-
}
47-
4818
//
4919
// Pointer store.
5020
//

‎benchmarks/FfiMemory/dart2/FfiMemory.dart

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -17,36 +17,6 @@ import 'dart:typed_data';
1717
import 'package:ffi/ffi.dart';
1818
import 'package:benchmark_harness/benchmark_harness.dart';
1919

20-
/// Represents a native unsigned pointer-sized integer in C.
21-
///
22-
/// [UintPtr] is not constructible in the Dart code and serves purely as marker in
23-
/// type signatures.
24-
@AbiSpecificIntegerMapping({
25-
Abi.androidArm: Uint32(),
26-
Abi.androidArm64: Uint64(),
27-
Abi.androidIA32: Uint32(),
28-
Abi.androidX64: Uint64(),
29-
Abi.fuchsiaArm64: Uint64(),
30-
Abi.fuchsiaX64: Uint64(),
31-
Abi.iosArm: Uint32(),
32-
Abi.iosArm64: Uint64(),
33-
Abi.iosX64: Uint64(),
34-
Abi.linuxArm: Uint32(),
35-
Abi.linuxArm64: Uint64(),
36-
Abi.linuxIA32: Uint32(),
37-
Abi.linuxX64: Uint64(),
38-
Abi.linuxRiscv32: Uint32(),
39-
Abi.linuxRiscv64: Uint64(),
40-
Abi.macosArm64: Uint64(),
41-
Abi.macosX64: Uint64(),
42-
Abi.windowsArm64: Uint64(),
43-
Abi.windowsIA32: Uint32(),
44-
Abi.windowsX64: Uint64(),
45-
})
46-
class UintPtr extends AbiSpecificInteger {
47-
const UintPtr();
48-
}
49-
5020
//
5121
// Pointer store.
5222
//

‎pkg/front_end/testcases/general/ffi_sample.dart.weak.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ constants {
4040

4141
Constructor coverage from constants:
4242
org-dartlang-testcase:///ffi_sample.dart:
43-
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:144:9)
43+
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:114:9)
4444
- _NativeDouble. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:34:9)
4545
- NativeType. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:12:9)
4646
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/general/ffi_sample.dart.weak.modular.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ constants {
4040

4141
Constructor coverage from constants:
4242
org-dartlang-testcase:///ffi_sample.dart:
43-
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:144:9)
43+
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:114:9)
4444
- _NativeDouble. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:34:9)
4545
- NativeType. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:12:9)
4646
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/general/ffi_sample.dart.weak.transformed.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ constants {
7474

7575
Constructor coverage from constants:
7676
org-dartlang-testcase:///ffi_sample.dart:
77-
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:144:9)
77+
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:114:9)
7878
- _NativeDouble. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:34:9)
7979
- NativeType. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:12:9)
8080
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/incremental/no_outline_change_50_ffi.yaml.world.1.expect

Lines changed: 28 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ additionalExports = (ffi::nullptr,
6363
ffi::FloatArray,
6464
ffi::FloatPointer,
6565
ffi::Handle,
66+
ffi::Int,
6667
ffi::Int16,
6768
ffi::Int16Array,
6869
ffi::Int16Pointer,
@@ -76,6 +77,8 @@ additionalExports = (ffi::nullptr,
7677
ffi::Int8Array,
7778
ffi::Int8Pointer,
7879
ffi::IntPtr,
80+
ffi::Long,
81+
ffi::LongLong,
7982
ffi::NativeApi,
8083
ffi::NativeFunction,
8184
ffi::NativeFunctionPointer,
@@ -86,6 +89,9 @@ additionalExports = (ffi::nullptr,
8689
ffi::Pointer,
8790
ffi::PointerArray,
8891
ffi::PointerPointer,
92+
ffi::Short,
93+
ffi::SignedChar,
94+
ffi::Size,
8995
ffi::Struct,
9096
ffi::StructArray,
9197
ffi::StructPointer,
@@ -101,11 +107,18 @@ additionalExports = (ffi::nullptr,
101107
ffi::Uint8,
102108
ffi::Uint8Array,
103109
ffi::Uint8Pointer,
110+
ffi::UintPtr,
104111
ffi::Union,
105112
ffi::UnionArray,
106113
ffi::UnionPointer,
114+
ffi::UnsignedChar,
115+
ffi::UnsignedInt,
116+
ffi::UnsignedLong,
117+
ffi::UnsignedLongLong,
118+
ffi::UnsignedShort,
107119
ffi::Unsized,
108-
ffi::Void)
120+
ffi::Void,
121+
ffi::WChar)
109122

110123
export "org-dartlang-test:///lib3.dart";
111124

@@ -139,6 +152,7 @@ additionalExports = (ffi::nullptr,
139152
ffi::FloatArray,
140153
ffi::FloatPointer,
141154
ffi::Handle,
155+
ffi::Int,
142156
ffi::Int16,
143157
ffi::Int16Array,
144158
ffi::Int16Pointer,
@@ -152,6 +166,8 @@ additionalExports = (ffi::nullptr,
152166
ffi::Int8Array,
153167
ffi::Int8Pointer,
154168
ffi::IntPtr,
169+
ffi::Long,
170+
ffi::LongLong,
155171
ffi::NativeApi,
156172
ffi::NativeFunction,
157173
ffi::NativeFunctionPointer,
@@ -162,6 +178,9 @@ additionalExports = (ffi::nullptr,
162178
ffi::Pointer,
163179
ffi::PointerArray,
164180
ffi::PointerPointer,
181+
ffi::Short,
182+
ffi::SignedChar,
183+
ffi::Size,
165184
ffi::Struct,
166185
ffi::StructArray,
167186
ffi::StructPointer,
@@ -177,11 +196,18 @@ additionalExports = (ffi::nullptr,
177196
ffi::Uint8,
178197
ffi::Uint8Array,
179198
ffi::Uint8Pointer,
199+
ffi::UintPtr,
180200
ffi::Union,
181201
ffi::UnionArray,
182202
ffi::UnionPointer,
203+
ffi::UnsignedChar,
204+
ffi::UnsignedInt,
205+
ffi::UnsignedLong,
206+
ffi::UnsignedLongLong,
207+
ffi::UnsignedShort,
183208
ffi::Unsized,
184-
ffi::Void)
209+
ffi::Void,
210+
ffi::WChar)
185211

186212
export "dart:ffi";
187213

‎pkg/front_end/testcases/incremental/no_outline_change_50_ffi.yaml.world.2.expect

Lines changed: 28 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ additionalExports = (ffi::nullptr,
6363
ffi::FloatArray,
6464
ffi::FloatPointer,
6565
ffi::Handle,
66+
ffi::Int,
6667
ffi::Int16,
6768
ffi::Int16Array,
6869
ffi::Int16Pointer,
@@ -76,6 +77,8 @@ additionalExports = (ffi::nullptr,
7677
ffi::Int8Array,
7778
ffi::Int8Pointer,
7879
ffi::IntPtr,
80+
ffi::Long,
81+
ffi::LongLong,
7982
ffi::NativeApi,
8083
ffi::NativeFunction,
8184
ffi::NativeFunctionPointer,
@@ -86,6 +89,9 @@ additionalExports = (ffi::nullptr,
8689
ffi::Pointer,
8790
ffi::PointerArray,
8891
ffi::PointerPointer,
92+
ffi::Short,
93+
ffi::SignedChar,
94+
ffi::Size,
8995
ffi::Struct,
9096
ffi::StructArray,
9197
ffi::StructPointer,
@@ -101,11 +107,18 @@ additionalExports = (ffi::nullptr,
101107
ffi::Uint8,
102108
ffi::Uint8Array,
103109
ffi::Uint8Pointer,
110+
ffi::UintPtr,
104111
ffi::Union,
105112
ffi::UnionArray,
106113
ffi::UnionPointer,
114+
ffi::UnsignedChar,
115+
ffi::UnsignedInt,
116+
ffi::UnsignedLong,
117+
ffi::UnsignedLongLong,
118+
ffi::UnsignedShort,
107119
ffi::Unsized,
108-
ffi::Void)
120+
ffi::Void,
121+
ffi::WChar)
109122

110123
export "org-dartlang-test:///lib3.dart";
111124

@@ -139,6 +152,7 @@ additionalExports = (ffi::nullptr,
139152
ffi::FloatArray,
140153
ffi::FloatPointer,
141154
ffi::Handle,
155+
ffi::Int,
142156
ffi::Int16,
143157
ffi::Int16Array,
144158
ffi::Int16Pointer,
@@ -152,6 +166,8 @@ additionalExports = (ffi::nullptr,
152166
ffi::Int8Array,
153167
ffi::Int8Pointer,
154168
ffi::IntPtr,
169+
ffi::Long,
170+
ffi::LongLong,
155171
ffi::NativeApi,
156172
ffi::NativeFunction,
157173
ffi::NativeFunctionPointer,
@@ -162,6 +178,9 @@ additionalExports = (ffi::nullptr,
162178
ffi::Pointer,
163179
ffi::PointerArray,
164180
ffi::PointerPointer,
181+
ffi::Short,
182+
ffi::SignedChar,
183+
ffi::Size,
165184
ffi::Struct,
166185
ffi::StructArray,
167186
ffi::StructPointer,
@@ -177,11 +196,18 @@ additionalExports = (ffi::nullptr,
177196
ffi::Uint8,
178197
ffi::Uint8Array,
179198
ffi::Uint8Pointer,
199+
ffi::UintPtr,
180200
ffi::Union,
181201
ffi::UnionArray,
182202
ffi::UnionPointer,
203+
ffi::UnsignedChar,
204+
ffi::UnsignedInt,
205+
ffi::UnsignedLong,
206+
ffi::UnsignedLongLong,
207+
ffi::UnsignedShort,
183208
ffi::Unsized,
184-
ffi::Void)
209+
ffi::Void,
210+
ffi::WChar)
185211

186212
export "dart:ffi";
187213

‎pkg/front_end/testcases/nnbd/ffi_sample.dart.strong.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ constants {
3434

3535
Constructor coverage from constants:
3636
org-dartlang-testcase:///ffi_sample.dart:
37-
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:144:9)
37+
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:114:9)
3838
- _NativeDouble. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:34:9)
3939
- NativeType. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:12:9)
4040
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_sample.dart.strong.transformed.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ constants {
6565

6666
Constructor coverage from constants:
6767
org-dartlang-testcase:///ffi_sample.dart:
68-
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:144:9)
68+
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:114:9)
6969
- _NativeDouble. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:34:9)
7070
- NativeType. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:12:9)
7171
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_sample.dart.weak.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ constants {
3434

3535
Constructor coverage from constants:
3636
org-dartlang-testcase:///ffi_sample.dart:
37-
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:144:9)
37+
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:114:9)
3838
- _NativeDouble. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:34:9)
3939
- NativeType. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:12:9)
4040
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_sample.dart.weak.modular.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ constants {
3434

3535
Constructor coverage from constants:
3636
org-dartlang-testcase:///ffi_sample.dart:
37-
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:144:9)
37+
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:114:9)
3838
- _NativeDouble. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:34:9)
3939
- NativeType. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:12:9)
4040
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_sample.dart.weak.transformed.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ constants {
6565

6666
Constructor coverage from constants:
6767
org-dartlang-testcase:///ffi_sample.dart:
68-
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:144:9)
68+
- Double. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:114:9)
6969
- _NativeDouble. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:34:9)
7070
- NativeType. (from org-dartlang-sdk:///sdk/lib/ffi/native_type.dart:12:9)
7171
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_struct_inline_array.dart.strong.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@ constants {
2525

2626
Constructor coverage from constants:
2727
org-dartlang-testcase:///ffi_struct_inline_array.dart:
28-
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:138:9)
28+
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:139:9)
2929
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_struct_inline_array.dart.strong.transformed.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,5 @@ constants {
5252

5353
Constructor coverage from constants:
5454
org-dartlang-testcase:///ffi_struct_inline_array.dart:
55-
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:138:9)
55+
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:139:9)
5656
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_struct_inline_array.dart.weak.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@ constants {
2525

2626
Constructor coverage from constants:
2727
org-dartlang-testcase:///ffi_struct_inline_array.dart:
28-
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:138:9)
28+
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:139:9)
2929
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_struct_inline_array.dart.weak.modular.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@ constants {
2525

2626
Constructor coverage from constants:
2727
org-dartlang-testcase:///ffi_struct_inline_array.dart:
28-
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:138:9)
28+
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:139:9)
2929
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_struct_inline_array.dart.weak.transformed.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,5 @@ constants {
5252

5353
Constructor coverage from constants:
5454
org-dartlang-testcase:///ffi_struct_inline_array.dart:
55-
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:138:9)
55+
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:139:9)
5656
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_struct_inline_array_multi_dimensional.dart.strong.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,5 @@ constants {
3333

3434
Constructor coverage from constants:
3535
org-dartlang-testcase:///ffi_struct_inline_array_multi_dimensional.dart:
36-
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:138:9)
36+
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:139:9)
3737
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_struct_inline_array_multi_dimensional.dart.strong.transformed.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,5 +84,5 @@ Extra constant evaluation: evaluated: 110, effectively constant: 2
8484

8585
Constructor coverage from constants:
8686
org-dartlang-testcase:///ffi_struct_inline_array_multi_dimensional.dart:
87-
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:138:9)
87+
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:139:9)
8888
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_struct_inline_array_multi_dimensional.dart.weak.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,5 @@ constants {
3333

3434
Constructor coverage from constants:
3535
org-dartlang-testcase:///ffi_struct_inline_array_multi_dimensional.dart:
36-
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:138:9)
36+
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:139:9)
3737
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

‎pkg/front_end/testcases/nnbd/ffi_struct_inline_array_multi_dimensional.dart.weak.modular.expect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,5 @@ constants {
3333

3434
Constructor coverage from constants:
3535
org-dartlang-testcase:///ffi_struct_inline_array_multi_dimensional.dart:
36-
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:138:9)
36+
- _ArraySize. (from org-dartlang-sdk:///sdk/lib/ffi/ffi.dart:139:9)
3737
- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart:25:9)

0 commit comments

Comments
 (0)