Skip to content

Commit 0766f7b

Browse files
elitreeCommit Queue
authored and
Commit Queue
committed
typo fixes: its vs. it's
Closes #55023 GitOrigin-RevId: f9457aa Change-Id: I29357eac563d6423a78ec58bbfa6a1a72e3dadf7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354501 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Nate Bosch <[email protected]> Commit-Queue: Michael Thomsen <[email protected]>
1 parent a19d3f3 commit 0766f7b

File tree

11 files changed

+14
-13
lines changed

11 files changed

+14
-13
lines changed

pkg/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ dart tools/package_deps/bin/package_deps.dart
1313
There are several packages developed in `pkg/` which are published to pub.
1414
Validation of these packages is particularly important because the pub tools are
1515
not used for these packages during development; we get our dependency versions
16-
from the DEPS file. Its very easy for the dependencies specified in a package's
16+
from the DEPS file. It's very easy for the dependencies specified in a package's
1717
pubspec file to get out of date wrt the packages and versions actually used.
1818

1919
In order to better ensure we're publishing correct packages, we validate some
@@ -38,6 +38,7 @@ are more informational as the pubspecs for these packages are not consumed by
3838
the pub tool or ecosystem.
3939

4040
We validate:
41+
4142
- that the dependencies listed in the pubspec are used in the package
4243
- that all the packages used by the source are listed in the pubspec
4344
- that a reference to a pkg/ package is done via a relative path dependency

pkg/_fe_analyzer_shared/lib/src/exhaustiveness/exhaustive.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ class _Checker {
294294
}
295295
}
296296

297-
/// Recursively expands [type] with its subtypes if its sealed.
297+
/// Recursively expands [type] with its subtypes if it's sealed.
298298
///
299299
/// Otherwise, just returns [type].
300300
List<StaticType> expandSealedSubtypes(

pkg/_fe_analyzer_shared/lib/src/macros/executor/remote_instance.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ abstract class RemoteInstance implements Serializable {
5151
@nonVirtual
5252
void serialize(Serializer serializer) {
5353
serializer.addInt(id);
54-
// We only send the ID if it's in the cache, its only in our cache if it is
54+
// We only send the ID if it's in the cache, it's only in our cache if it is
5555
// also in the remote cache.
5656
if (_remoteInstanceCache.containsKey(id)) return;
5757

pkg/_fe_analyzer_shared/lib/src/macros/executor/serialization.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ class JsonDeserializer implements Deserializer {
240240
_initialized = true;
241241
}
242242

243-
// Move the current iterable, if its at the end of its items remove it from
243+
// Move the current iterable, if it's at the end of its items remove it from
244244
// the current path and return false.
245245
if (!_path.last.moveNext()) {
246246
_path.removeLast();

pkg/analyzer/lib/src/workspace/pub.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ class PackageConfigWorkspace extends SimpleWorkspace {
206206

207207
/// For some package file, which may or may not be a package source (it could
208208
/// be in `bin/`, `web/`, etc), find where its built counterpart will exist if
209-
/// its a generated source.
209+
/// it's a generated source.
210210
///
211211
/// To get a [builtPath] for a package source file to use in this method,
212212
/// use [_builtPackageSourcePath]. For `bin/`, `web/`, etc, it must be relative

pkg/linter/doc/use_build_context_synchronously.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ This calculation is based on a few simple properties:
8181
* We implement this calculation with a standard SimpleVisitor from the analyzer.
8282
We create the visitor with **child** as the reference node to consider. Each
8383
visit method descends down various child nodes, receiving their returned
84-
"async state" in order to calculate the state of it's own visited node,
84+
"async state" in order to calculate the state of its own visited node,
8585
relative to **child**.
8686
* At the entrypoint of the visitation, **child**'s parent is **parent**. Then we
8787
descend into **parent**'s various descendents, and so for every other visit
@@ -116,4 +116,4 @@ This calculation is based on a few simple properties:
116116
then-statement, but not the else-statement, and no statements that follow the
117117
IfStatement. An IfStatement with a condition like `!context.mounted` and a
118118
then-statement that definitely exits (e.g. with a return or a throw),
119-
definitely guards the statements that follow it.
119+
definitely guards the statements that follow it.

pkg/linter/lib/src/rules/dangling_library_doc_comments.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ class _Visitor extends SimpleAstVisitor<void> {
154154

155155
var commentEndLine = lineInfo.getLocation(commentToken.end).lineNumber;
156156
// The syntactic entity to which a comment is "attached" is the
157-
// [Comment]'s `parent`, not it's `endToken`'s `next` [Token].
157+
// [Comment]'s `parent`, not its `endToken`'s `next` [Token].
158158
var tokenAfterDocComment =
159159
(docComment.endToken as DocumentationCommentToken).parent;
160160
if (tokenAfterDocComment == null) {

pkg/linter/lib/src/rules/prefer_const_constructors_in_immutables.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ class _Visitor extends SimpleAstVisitor<void> {
129129
return unnamedSuperConstructor != null && unnamedSuperConstructor.isConst;
130130
}
131131

132-
/// Whether [clazz] or any of it's super-types are annotated with
132+
/// Whether [clazz] or any of its super-types are annotated with
133133
/// `@immutable`.
134134
bool _hasImmutableAnnotation(InterfaceElement clazz) {
135135
var selfAndInheritedClasses = _getSelfAndSuperClasses(clazz);

pkg/linter/lib/src/rules/prefer_double_quotes.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ quote isn't escaped (note: we don't lint the other way around, ie, a double
1616
quoted string with an escaped double quote is not flagged).
1717
1818
It's also rare, but possible, to have strings within string interpolations. In
19-
this case, its much more readable to use a single quote somewhere. So single
19+
this case, it's much more readable to use a single quote somewhere. So single
2020
quotes are allowed either within, or containing, an interpolated string literal.
2121
Arguably strings within string interpolations should be its own type of lint.
2222

pkg/linter/lib/src/rules/prefer_single_quotes.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ apostrophe isn't escaped (note: we don't lint the other way around, ie, a single
1717
quoted string with an escaped apostrophe is not flagged).
1818
1919
It's also rare, but possible, to have strings within string interpolations. In
20-
this case, its much more readable to use a double quote somewhere. So double
20+
this case, it's much more readable to use a double quote somewhere. So double
2121
quotes are allowed either within, or containing, an interpolated string literal.
2222
Arguably strings within string interpolations should be its own type of lint.
2323

pkg/linter/tool/machine/rules.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1796,7 +1796,7 @@
17961796
],
17971797
"sets": [],
17981798
"fixStatus": "hasFix",
1799-
"details": "**DO** use double quotes where they wouldn't require additional escapes.\n\nThat means strings with a double quote may use apostrophes so that the double\nquote isn't escaped (note: we don't lint the other way around, ie, a double\nquoted string with an escaped double quote is not flagged).\n\nIt's also rare, but possible, to have strings within string interpolations. In\nthis case, its much more readable to use a single quote somewhere. So single\nquotes are allowed either within, or containing, an interpolated string literal.\nArguably strings within string interpolations should be its own type of lint.\n\n**BAD:**\n```dart\nuseStrings(\n 'should be double quote',\n r'should be double quote',\n r'''should be double quotes''')\n```\n\n**GOOD:**\n```dart\nuseStrings(\n \"should be double quote\",\n r\"should be double quote\",\n r\"\"\"should be double quotes\"\"\",\n 'ok with \" inside',\n 'nested ${a ? \"strings\" : \"can\"} be wrapped by a double quote',\n \"and nested ${a ? 'strings' : 'can be double quoted themselves'}\");\n```\n\n",
1799+
"details": "**DO** use double quotes where they wouldn't require additional escapes.\n\nThat means strings with a double quote may use apostrophes so that the double\nquote isn't escaped (note: we don't lint the other way around, ie, a double\nquoted string with an escaped double quote is not flagged).\n\nIt's also rare, but possible, to have strings within string interpolations. In\nthis case, it's much more readable to use a single quote somewhere. So single\nquotes are allowed either within, or containing, an interpolated string literal.\nArguably strings within string interpolations should be its own type of lint.\n\n**BAD:**\n```dart\nuseStrings(\n 'should be double quote',\n r'should be double quote',\n r'''should be double quotes''')\n```\n\n**GOOD:**\n```dart\nuseStrings(\n \"should be double quote\",\n r\"should be double quote\",\n r\"\"\"should be double quotes\"\"\",\n 'ok with \" inside',\n 'nested ${a ? \"strings\" : \"can\"} be wrapped by a double quote',\n \"and nested ${a ? 'strings' : 'can be double quoted themselves'}\");\n```\n\n",
18001800
"sinceDartSdk": "2.4.0"
18011801
},
18021802
{
@@ -2110,7 +2110,7 @@
21102110
],
21112111
"sets": [],
21122112
"fixStatus": "hasFix",
2113-
"details": "**DO** use single quotes where they wouldn't require additional escapes.\n\nThat means strings with an apostrophe may use double quotes so that the\napostrophe isn't escaped (note: we don't lint the other way around, ie, a single\nquoted string with an escaped apostrophe is not flagged).\n\nIt's also rare, but possible, to have strings within string interpolations. In\nthis case, its much more readable to use a double quote somewhere. So double\nquotes are allowed either within, or containing, an interpolated string literal.\nArguably strings within string interpolations should be its own type of lint.\n\n**BAD:**\n```dart\nuseStrings(\n \"should be single quote\",\n r\"should be single quote\",\n r\"\"\"should be single quotes\"\"\")\n```\n\n**GOOD:**\n```dart\nuseStrings(\n 'should be single quote',\n r'should be single quote',\n r'''should be single quotes''',\n \"here's ok\",\n \"nested ${a ? 'strings' : 'can'} be wrapped by a double quote\",\n 'and nested ${a ? \"strings\" : \"can be double quoted themselves\"}');\n```\n\n",
2113+
"details": "**DO** use single quotes where they wouldn't require additional escapes.\n\nThat means strings with an apostrophe may use double quotes so that the\napostrophe isn't escaped (note: we don't lint the other way around, ie, a single\nquoted string with an escaped apostrophe is not flagged).\n\nIt's also rare, but possible, to have strings within string interpolations. In\nthis case, it's much more readable to use a double quote somewhere. So double\nquotes are allowed either within, or containing, an interpolated string literal.\nArguably strings within string interpolations should be its own type of lint.\n\n**BAD:**\n```dart\nuseStrings(\n \"should be single quote\",\n r\"should be single quote\",\n r\"\"\"should be single quotes\"\"\")\n```\n\n**GOOD:**\n```dart\nuseStrings(\n 'should be single quote',\n r'should be single quote',\n r'''should be single quotes''',\n \"here's ok\",\n \"nested ${a ? 'strings' : 'can'} be wrapped by a double quote\",\n 'and nested ${a ? \"strings\" : \"can be double quoted themselves\"}');\n```\n\n",
21142114
"sinceDartSdk": "2.0.0"
21152115
},
21162116
{

0 commit comments

Comments
 (0)